Snappy

Merge lp://qastaging/~mvo/snappy/snappy-snapfs-os-kernel into lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github

snappy-snapfs-os-kernel
Merge into snappy-moved-to-github

Proposed by Michael Vogt on 2015-10-19

Status:	Needs review
Proposed branch:	lp://qastaging/~mvo/snappy/snappy-snapfs-os-kernel
Merge into:	lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github
Prerequisite:	lp://qastaging/~mvo/snappy/snappy-snapfs-mount
Diff against target:	831 lines (+360/-54) 18 files modified cmd/snappy/cmd_internal_unpack.go (+1/-1) partition/assets.go (+1/-1) partition/bootloader.go (+28/-8) partition/bootloader_grub.go (+15/-15) partition/bootloader_test.go (+4/-4) partition/bootloader_uboot.go (+7/-3) partition/migrate_grub.go (+1/-1) partition/partition_test.go (+7/-4) pkg/clickdeb/deb.go (+7/-3) pkg/clickdeb/deb_test.go (+2/-2) pkg/file.go (+1/-0) pkg/types.go (+2/-0) snappy/common_test.go (+19/-2) snappy/kernel.go (+69/-0) snappy/snapp.go (+51/-2) snappy/snapp_snapfs_test.go (+143/-6) snappy/systemimage.go (+1/-1) snappy/systemimage_test.go (+1/-1)
To merge this branch:	bzr merge lp://qastaging/~mvo/snappy/snappy-snapfs-os-kernel
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
John Lenton (community)		2015-10-19	Needs Fixing on 2015-10-20
Review via email: mp+274859@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-10-19.

Description of the change

Unpack kernel assets, setup bootloader vars for kernel/os snap. Combined with the updated initramfs-tools-ubuntu-core and a matching oem snap this will give us a booting system (but not much more :)

Lots of cleanup needed, but I want to avoid a gigantic branch so approaching it in steps.

Revision history for this message

Michael Vogt (mvo) wrote on 2015-10-19:

Review would be great, I plan to add more tests later tonight/tomorrow morning only (i.e. kernel unpack tests).

lp://qastaging/~mvo/snappy/snappy-snapfs-os-kernel updated on 2015-10-20

772. By Michael Vogt on 2015-10-19: add assets unpack test
773. By Michael Vogt on 2015-10-19: mered lp:snappy
774. By Michael Vogt on 2015-10-19: fix tests
775. By Michael Vogt on 2015-10-20: go fmt
776. By Michael Vogt on 2015-10-20: partition/partition_test.go: fix bootloaderName

Revision history for this message

John Lenton (chipaca) wrote on 2015-10-20:

Mostly lint fixes. Some "you should probably play extra safe here" sync-after-everything fixes.

review: Needs Fixing

Revision history for this message

Michael Vogt (mvo) wrote on 2015-10-29:

Thanks John! I updated the branch based on your feedback (on github though).

Unmerged revisions

776. By Michael Vogt on 2015-10-20: partition/partition_test.go: fix bootloaderName
775. By Michael Vogt on 2015-10-20: go fmt
774. By Michael Vogt on 2015-10-19: fix tests
773. By Michael Vogt on 2015-10-19: mered lp:snappy
772. By Michael Vogt on 2015-10-19: add assets unpack test
771. By Michael Vogt on 2015-10-19: more FIXME
770. By Michael Vogt on 2015-10-19: improve fixme
769. By Michael Vogt on 2015-10-19: add missing tests
768. By Michael Vogt on 2015-10-19: do not reimplement normalizeKernelInitrdName but instead export it
767. By Michael Vogt on 2015-10-19: unpack kernel assets and setup the right boot variables for kernel/os snaps