Merge lp://qastaging/~mvo/snappy/unexport-more into lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github
Status: | Work in progress |
---|---|
Proposed branch: | lp://qastaging/~mvo/snappy/unexport-more |
Merge into: | lp://qastaging/~snappy-dev/snappy/snappy-moved-to-github |
Diff against target: |
1041 lines (+162/-157) 11 files modified
cmd/snappy-go/cmd_booted.go (+1/-6) cmd/snappy-go/cmd_info.go (+1/-1) snappy/click_test.go (+3/-3) snappy/config.go (+1/-1) snappy/helpers.go (+1/-1) snappy/helpers_test.go (+1/-1) snappy/parts.go (+10/-10) snappy/snapp.go (+67/-67) snappy/snapp_test.go (+11/-11) snappy/systemimage.go (+58/-48) snappy/systemimage_test.go (+8/-8) |
To merge this branch: | bzr merge lp://qastaging/~mvo/snappy/unexport-more |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Schvezov | Needs Information | ||
Review via email:
|
Commit message
unexport implementation details for snap repositories and snap types
Description of the change
This branch unexports more implementation details inside snappy/. The
different repository and snap implementations are hidden. The exported
API for this is the "Part" interface and the "MetaRepository" plus
the various query helpers (like ActiveSnapByName).
If that turns out to be not sufficient we can export more API, but I
would like to provide only a minimal version for now so that we can
change the way we handle the repositories internally easily.
Unmerged revisions
- 179. By Michael Vogt
-
merged lp:snappy and resolve conflicts
- 178. By Michael Vogt
-
unexport implementation details of repositories and individual snap types. MetaRepository and the Part interface are the only exported API (for now)
I'm all for this, but not sure how this impacts the webdm work; can MetaRepository be setup to only search locally?
In the case of implementing "Ports" for installed packages we'd need to infer the real Part to be able to call it's .Ports() receiver (which is not written yet); will this still work?