Merge lp://qastaging/~mvo/software-center/lp917096 into lp://qastaging/software-center

Proposed by Michael Vogt
Status: Merged
Merged at revision: 2768
Proposed branch: lp://qastaging/~mvo/software-center/lp917096
Merge into: lp://qastaging/software-center
Diff against target: 263 lines (+100/-28)
8 files modified
debian/changelog (+7/-0)
softwarecenter/db/__init__.py (+3/-1)
softwarecenter/db/application.py (+2/-1)
softwarecenter/db/debfile.py (+12/-10)
softwarecenter/ui/gtk3/panes/availablepane.py (+7/-2)
softwarecenter/ui/gtk3/views/appdetailsview.py (+11/-9)
test/gtk3/test_debfile_view.py (+47/-0)
test/test_debfileapplication.py (+11/-5)
To merge this branch: bzr merge lp://qastaging/~mvo/software-center/lp917096
Reviewer Review Type Date Requested Status
Gary Lasker (community) Approve
Review via email: mp+93371@code.qastaging.launchpad.net

Description of the change

This fixes various issues around the debfile handling.

- it no longer crashes when viewing a debfile
- if a debfile is not installable it shows a error and hides the action button
- adds tests for this behavior

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Looks great, thanks mvo!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches