Merge lp://qastaging/~mvo/ubuntu-release-upgrader/install-linux-metapackage-tweaks into lp://qastaging/ubuntu-release-upgrader

Proposed by Michael Vogt
Status: Merged
Merged at revision: 2927
Proposed branch: lp://qastaging/~mvo/ubuntu-release-upgrader/install-linux-metapackage-tweaks
Merge into: lp://qastaging/ubuntu-release-upgrader
Diff against target: 76 lines (+26/-11)
2 files modified
DistUpgrade/DistUpgradeQuirks.py (+4/-11)
tests/test_quirks.py (+22/-0)
To merge this branch: bzr merge lp://qastaging/~mvo/ubuntu-release-upgrader/install-linux-metapackage-tweaks
Reviewer Review Type Date Requested Status
Brian Murray Approve
Review via email: mp+275822@code.qastaging.launchpad.net

Description of the change

Tiny branch that adds a test and uses the build-in version compare instead of spawning dpkg. I would love to add some more tests around this code especially around the "Source" version compare but I ran out of time.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

Thanks! I've merged this and then I added some more tests for different linux meta packages, but I'm not sure if that is what you had in mind by 'around the "Source" version compare'.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches