Release Upgrader

Merge lp://qastaging/~mvo/ubuntu-release-upgrader/text-install-progress into lp://qastaging/ubuntu-release-upgrader

  1. text-install-progress
  2. Merge into trunk
Proposed by Michael Vogt
Status: Merged
Merged at revision: 2796
Proposed branch: lp://qastaging/~mvo/ubuntu-release-upgrader/text-install-progress
Merge into: lp://qastaging/ubuntu-release-upgrader
Diff against target: 61 lines (+31/-1)
2 files modified
DistUpgrade/DistUpgradeViewText.py (+20/-1)
README.devel (+11/-0)
To merge this branch: bzr merge lp://qastaging/~mvo/ubuntu-release-upgrader/text-install-progress
Reviewer Review Type Date Requested Status
Brian Murray Approve
Review via email: mp+176872@code.qastaging.launchpad.net

Description of the change

This tiny branch adds progress information into the text-mode upgrader.
Useful to guess how long the upgrade will take.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

P.S. If this looks good I'm happy to do the merge/upload, just want to have a additional pair of eyes on it.

Revision history for this message
Brian Murray (brian-murray) wrote :

I saw Total Progess [02.02] which doesn't seem that informative to me. A whole number followed by a percent sign would be more informative e.g. "Total Progress [22%]".

review: Needs Fixing
Revision history for this message
Michael Vogt (mvo) wrote :

Indeed, good point. I added the "%" at the end now.

Revision history for this message
Michael Vogt (mvo) wrote :

Is there a chance that this gets in for trusty?

It would be nice to have some progress reporting for users who do server upgrades. But I understand that the added string will probably need a exception (or multiple ones) at this point.

Thanks,
 Michael

Revision history for this message
Michael Vogt (mvo) wrote :

I updated the branch now so that it avoids a string break. Still a FeatureFreezeException required I guess.

Revision history for this message
Brian Murray (brian-murray) wrote :

The file README.devel actually contains a typo or two in that it mentions ubuntu-release-upgrade not ubuntu-release-upgrader.

Revision history for this message
Brian Murray (brian-murray) wrote :

I've tested this again and see "Progress [ 15%]" now, so this looks good to me. Sorry for the delay in getting this reviewed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches