Merge lp://qastaging/~mvo/ubuntu-system-image/lp1271684 into lp://qastaging/~registry/ubuntu-system-image/client
Proposed by
Michael Vogt
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Barry Warsaw | ||||
| Approved revision: | 259 | ||||
| Merge reported by: | Barry Warsaw | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp://qastaging/~mvo/ubuntu-system-image/lp1271684 | ||||
| Merge into: | lp://qastaging/~registry/ubuntu-system-image/client | ||||
| Diff against target: |
157 lines (+58/-10) 5 files modified
README (+15/-0) systemimage/gpg.py (+8/-5) systemimage/helpers.py (+15/-0) systemimage/state.py (+3/-3) systemimage/tests/test_helpers.py (+17/-2) |
||||
| To merge this branch: | bzr merge lp://qastaging/~mvo/ubuntu-system-image/lp1271684 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Barry Warsaw (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch makes system-image more memory efficient when calculating the file signatures. This fixes lp:1271684.
Its a bit of a drive-by branch, I stumbled over the bug and it looked easy enough to get familiar with the code.
Note that I added a README to help new developers getting into the code, I had trouble running the full testsuite, I'm happy to replace the "???" in the README with the proper command. I tried "python3 -m nose2 -v" but that fails early in find_dbus_process on my utopic system.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi Michael - thanks for this branch! Somehow I missed this bug. The branch looks good, I'll merge this into trunk for s-i 2.3. Thanks!
FWIW, you can just run `tox` at the command line to run the test suite. That has the side-effect of building the environment to run the tests. `python3 -m nose2 -v` *can* work, but it may not have everything set up. I'll update the README with details.