ubuntuone-installer

Merge lp://qastaging/~mvo/ubuntuone-installer/lp853060 into lp://qastaging/ubuntuone-installer

  1. lp853060
  2. Merge into trunk
Proposed by Michael Vogt
Status: Rejected
Rejected by: dobey
Proposed branch: lp://qastaging/~mvo/ubuntuone-installer/lp853060
Merge into: lp://qastaging/ubuntuone-installer
Diff against target: 23 lines (+4/-2)
1 file modified
ubuntuone/installer/gui.py (+4/-2)
To merge this branch: bzr merge lp://qastaging/~mvo/ubuntuone-installer/lp853060
Reviewer Review Type Date Requested Status
dobey (community) Needs Information
Review via email: mp+105247@code.qastaging.launchpad.net

Description of the change

This should fix bug #853060 by checking for the exit-status. Someone will have to test it.

To post a comment you must log in.
lp://qastaging/~mvo/ubuntuone-installer/lp853060 updated
27. By Michael Vogt

empty --fixes commit for #853060

Revision history for this message
dobey (dobey) wrote :

I'm trying to reproduce the problem, but only get a working result. Would like to understand what is going wrong exactly for people so we can have a proper test case for regression testing.

review: Needs Information
Revision history for this message
Michael Vogt (mvo) wrote :

As was pointed out, this needs some more work to actually show a proper error dialog.
aptdaemon does support this via ready-made gtk/gtk3 error dialogs that we need to wire in.

Revision history for this message
dobey (dobey) wrote :

Rejected this one, as I have a branch in the works which adds error handling and such.

Unmerged revisions

27. By Michael Vogt

empty --fixes commit for #853060

26. By Michael Vogt

ubuntuone/installer/gui.py: check for exit-status before launching CONTROL_PANEL_COMMAND

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches