LAVA Android Test

Merge lp://qastaging/~mwhudson/lava-android-test/add-setup.cfg-workaround-bug-988710 into lp://qastaging/lava-android-test

add-setup.cfg-workaround-bug-988710
Merge into trunk

Proposed by Michael Hudson-Doyle on 2012-04-29

Status:

Merged

Merged at revision:

152

Proposed branch:

lp://qastaging/~mwhudson/lava-android-test/add-setup.cfg-workaround-bug-988710

Merge into:

lp://qastaging/lava-android-test

Diff against target:

6 lines (+2/-0)

1 file modified

setup.cfg (+2/-0)

To merge this branch:

bzr merge lp://qastaging/~mwhudson/lava-android-test/add-setup.cfg-workaround-bug-988710

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Yongqin Liu		2012-04-29	Approve on 2012-05-09
Review via email: mp+104051@code.qastaging.launchpad.net

Description of the change

Please see the comments on the linked bug report for why this helps.

Revision history for this message

Yongqin Liu (liuyq0307) wrote on 2012-05-09:

I don't if it's right. but I believe that it is right:)

BTW, before we merge it to trunk, how can I verify that the problem has been resolved?

review: Approve

Revision history for this message

Andy Doan (doanac) wrote on 2012-05-09:

On 05/09/2012 01:37 AM, Yongqin Liu wrote:
> I don't if it's right. but I believe that it is right:)

Best review comment I've ever read! :)

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2012-05-09:

On Wed, 09 May 2012 06:37:17 -0000, Yongqin Liu <email address hidden> wrote:
> Review: Approve
>
> I don't if it's right. but I believe that it is right:)
>
> BTW, before we merge it to trunk, how can I verify that the problem has been resolved?

I think the way to check is this: before, when you run "python setup.py
sdist" you get a tarball that contains setup.cfg but the
lava_android_test.egg-info/SOURCES.txt file in the tarball does not list
setup.cfg. After, SOURCES.txt lists setup.cfg.

Cheers,
mwh

Revision history for this message

Yongqin Liu (liuyq0307) wrote on 2012-05-17:

> On Wed, 09 May 2012 06:37:17 -0000, Yongqin Liu <email address hidden>
> wrote:
> > Review: Approve
> >
> > I don't if it's right. but I believe that it is right:)
> >
> > BTW, before we merge it to trunk, how can I verify that the problem has been
> resolved?
>
> I think the way to check is this: before, when you run "python setup.py
> sdist" you get a tarball that contains setup.cfg but the
> lava_android_test.egg-info/SOURCES.txt file in the tarball does not list
> setup.cfg. After, SOURCES.txt lists setup.cfg.
>
By this way, it's right:)
Merge first.