libmemcached

Merge lp://qastaging/~mwhudson/libmemcached/misc-memaslap-fixes into lp://qastaging/libmemcached

  1. misc-memaslap-fixes
  2. Merge into 1.2
Proposed by Michael Hudson-Doyle
Status: Merged
Merged at revision: 1108
Proposed branch: lp://qastaging/~mwhudson/libmemcached/misc-memaslap-fixes
Merge into: lp://qastaging/libmemcached
Diff against target: 142 lines (+19/-14)
7 files modified
clients/include.am (+4/-0)
clients/memaslap.c (+4/-5)
clients/ms_memslap.h (+3/-3)
clients/ms_setting.c (+1/-1)
clients/ms_stats.c (+5/-2)
clients/ms_task.c (+2/-2)
m4/ax_harden_compiler_flags.m4 (+0/-1)
To merge this branch: bzr merge lp://qastaging/~mwhudson/libmemcached/misc-memaslap-fixes
Reviewer Review Type Date Requested Status
Tangent Trunk Pending
Review via email: mp+188753@code.qastaging.launchpad.net

Description of the change

Hi,

I've been using memaslap a bit and ran into an assortment of little problems, all fixed in this branch. Please see the individual commits for details. I can split this up into more single-purpose branches if that would be preferable.

Cheers,
mwh

To post a comment you must log in.
Revision history for this message
Brian Aker (brianaker) wrote :

memaslap was written by some folks who didn't maintain it... and frankly it is so ugly I tend to not to want to either.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Well, I can make another merge proposal that deletes it if that would be better :)

It seemed more capable and informative than memslap.

Revision history for this message
Brian Aker (brianaker) wrote :

BTW I am looking into why this seems to be failing in the build system.

Revision history for this message
Brian Aker (brianaker) wrote :

Why did you comment out -Wunsuffixed-float-constants?

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Brian Aker <email address hidden> writes:

> Why did you comment out -Wunsuffixed-float-constants?

Because putting 'd' after all the floating point constants seemed really
tedious and the syntax is only supported by relatively new versions of
gcc (gcc.gnu.org/bugzilla/show_bug.cgi?id=39027 -- well, 4.5, I guess
that's fairly old now).

FWIW, memaslap contains the only floaing point constants in the entire
codebase, as far as I could tell.

Cheers,
mwh

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: