Merge lp://qastaging/~mwhudson/linaro-android-build-tools/submit-to-owned-stream into lp://qastaging/linaro-android-build-tools

Proposed by Michael Hudson-Doyle
Status: Merged
Approved by: Paul Sokolovsky
Approved revision: 429
Merged at revision: 445
Proposed branch: lp://qastaging/~mwhudson/linaro-android-build-tools/submit-to-owned-stream
Merge into: lp://qastaging/linaro-android-build-tools
Diff against target: 90 lines (+9/-14)
1 file modified
build-scripts/post-build-lava.py (+9/-14)
To merge this branch: bzr merge lp://qastaging/~mwhudson/linaro-android-build-tools/submit-to-owned-stream
Reviewer Review Type Date Requested Status
James Tunnicliffe (community) Approve
Paul Sokolovsky Approve
Review via email: mp+99249@code.qastaging.launchpad.net

Description of the change

Hi, this branch changes the build script to submit LAVA jobs that submit to owned streams (we're trying to phase out the usage of anonymous streams in LAVA).

I removed some unused generality. If you really need to submit different results to different streams, that will require a little bit more shuffling, or being able to put templates in PRODUCT_MAP or something, but that seems like it can be deferred until it's needed.

Cheers,
mwh

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Ping?

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

My only concern are if frontend changes would be required to support this? Otherwise, looks good.

review: Approve
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Looks fine to me.

review: Approve
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Thanks for the reviews James & Paul.

On Mon, 02 Apr 2012 12:04:26 -0000, Paul Sokolovsky <email address hidden> wrote:
> Review: Approve
>
> My only concern are if frontend changes would be required to support
> this? Otherwise, looks good.

The frontend works in job and bundle ids, so is unaffected by the stream
submitted to.

If we ever want to start submitting to private bundle streams we should
make some changes so that the experience for users who are not logged in
to validation.linaro.org is understandable, but that can come later :)

Cheers,
mwh

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Ok, kinda though Michael may want to merge this himself at the right time for this, but let me do this so it didn't sleep.

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

slip

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

On Thu, 19 Apr 2012 08:02:28 -0000, Paul Sokolovsky <email address hidden> wrote:
> Ok, kinda though Michael may want to merge this himself at the right time for this, but let me do this so it didn't sleep.

I don't think I could have :-) I'm not in ~linaro-infrastructure any
more.

Cheers,
mwh

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches