Merge ~mwhudson/utah/+git/utah:use-communicate into utah:master
Proposed by
Michael Hudson-Doyle
| Status: | Merged |
|---|---|
| Approved by: | Paride Legovini |
| Approved revision: | 181d395a5e93f6dcdb48d49ebfae7e302cc5f96e |
| Merged at revision: | 7b984c27e8652886a5a5874279a5aa830bf9fd78 |
| Proposed branch: | ~mwhudson/utah/+git/utah:use-communicate |
| Merge into: | utah:master |
| Diff against target: |
24 lines (+2/-6) 1 file modified
utah/process.py (+2/-6) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paride Legovini | Approve | ||
|
Review via email:
|
|||
Commit message
use Popen.communicate in ProcessRunnner
Probably ProcessRunnner could be done away with entirely but the
existing implementation didn't always collect _all_ of the subprocess'
output, which is a problem if you're trying to interpret it as JSON.
Description of the change
Yes I was very angry when I wrote this, why do you ask?
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM