Ubuntu Notes app

Merge lp://qastaging/~mzanetti/reminders-app/libqtevernote into lp://qastaging/reminders-app

  1. libqtevernote
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Michael Zanetti
Approved revision: 288
Merged at revision: 292
Proposed branch: lp://qastaging/~mzanetti/reminders-app/libqtevernote
Merge into: lp://qastaging/reminders-app
Diff against target: 389 lines (+92/-69)
9 files modified
3rdParty/evernote-sdk-cpp/CMakeLists.txt (+2/-1)
3rdParty/libthrift/CMakeLists.txt (+4/-1)
CMakeLists.txt (+1/-0)
debian/control (+1/-0)
po/com.ubuntu.reminders.pot (+28/-28)
src/CMakeLists.txt (+5/-0)
src/libqtevernote/CMakeLists.txt (+46/-0)
src/plugin/CMakeLists.txt (+0/-5)
src/plugin/Evernote/CMakeLists.txt (+5/-34)
To merge this branch: bzr merge lp://qastaging/~mzanetti/reminders-app/libqtevernote
Reviewer Review Type Date Requested Status
Penk Chen (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+239496@code.qastaging.launchpad.net

Commit message

Split the actual evernote code out from the QML plugin into a libqtevernote

Description of the change

Split the actual evernote code out from the QML plugin into a libqtevernote

To post a comment you must log in.
lp://qastaging/~mzanetti/reminders-app/libqtevernote updated
287. By Michael Zanetti

move evernote code into a libqtevernote

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:287
http://91.189.93.70:8080/job/reminders-app-ci/564/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1227/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/260/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/564/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~mzanetti/reminders-app/libqtevernote updated
288. By Michael Zanetti

add pkg-config to build-deps

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:288
http://91.189.93.70:8080/job/reminders-app-ci/565/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1246
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1246/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/261

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/565/rebuild

review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

I've been testing this branch and manually exercising all features of the app. Overall it seems to work all fine.

However, I've noticed a regression that I'm not sure if it's been introduced on this branch or previously: the reminders page does not classify the dates of the reminders correctly. E.g. if I set a reminder to today, it shows it under "Overdue", whereas the truly overdue ones are shown under "Today".

Revision history for this message
Penk Chen (penk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches