Merge lp://qastaging/~mzanetti/reminders-app/notes-headers into lp://qastaging/~notes-app-dev/reminders-app/new-design
Proposed by
Michael Zanetti
Status: | Superseded |
---|---|
Proposed branch: | lp://qastaging/~mzanetti/reminders-app/notes-headers |
Merge into: | lp://qastaging/~notes-app-dev/reminders-app/new-design |
Diff against target: |
229 lines (+72/-9) 8 files modified
debian/control (+1/-0) src/app/qml/ui/NotesPage.qml (+18/-0) src/plugin/Evernote/note.cpp (+28/-6) src/plugin/Evernote/note.h (+2/-0) src/plugin/Evernote/notes.cpp (+16/-2) src/plugin/Evernote/notes.h (+2/-0) src/plugin/Evernote/notesstore.cpp (+3/-0) src/plugin/Evernote/notesstore.h (+2/-1) |
To merge this branch: | bzr merge lp://qastaging/~mzanetti/reminders-app/notes-headers |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Planella | Needs Fixing | ||
Review via email: mp+218328@code.qastaging.launchpad.net |
Commit message
added sectionheaders to NotesList as per new design
To post a comment you must log in.
Unmerged revisions
- 99. By Michael Zanetti
-
d'oh!
- 98. By Michael Zanetti
-
make it translatable
Just one thing I've noticed at a quick glance before testing it on a device:
61 + return QStringLiteral( "Today" );
This string (and all of those inside that same function) needs to be internationalized, either using the i18n plugin from the SDK (I still couldn't figure out whether it can be used from C++ or only from QML) or with plain gettext (which should work in any case).