Merge lp://qastaging/~mzanetti/reminders-app/qmltest2 into lp://qastaging/reminders-app

FAILED: Continuous integration, rev:296
http://91.189.93.70:8080/job/reminders-app-ci/723/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2381/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/325/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/144/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/723/rebuild

FAILED: Continuous integration, rev:297
http://91.189.93.70:8080/job/reminders-app-ci/725/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2385/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/327/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/146/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/725/rebuild

FAILED: Continuous integration, rev:298
http://91.189.93.70:8080/job/reminders-app-ci/727/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2387/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/329/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/148/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/727/rebuild

FAILED: Continuous integration, rev:297
http://91.189.93.70:8080/job/reminders-app-ci/728/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2388/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/330/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/149/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/728/rebuild

FAILED: Continuous integration, rev:297
http://91.189.93.70:8080/job/reminders-app-ci/729/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2389/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/331/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/151/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/729/rebuild

There is one test failing:

FAIL! : qmltestrunner::notebooksDelegateTestCase::test_createNoteFromBottomEdge() property count

Also, there are many warnings on the test output. It would be great to fix them, or silence the ones that are expected. This branch is already big, so that can be done separately.

173 + print("closing editview")

Is it right to print to console? Shouldn't this go to a log file?

576 + //wait(500)

That commented code can be removed.

581 + wait(500)
582 + //waitForRendering(mainView)

Can we use the waitForRendering instead of the hardcoded sleep?
If not, please remove the commented statement, and add a comment on the sleep so others reading the code understand why it was added.

596 + var x = mainView.width / 2;
[...]
601 + mouseRelease(mainView, x, startY + dY)

It would be nice to wrap this into a function with a nice name.

610 + // clear the textField
611 + mouseClick(titleTextField, titleTextField.width - units.gu(1), titleTextField.height / 2);
612 + compare(titleTextField.text, "");

If this is a normal textfield from the SDK, then clearing has already been tested. I would make the test shorter by just doing titleTextField.text = "".

639 + var x = delegate.width / 2
[...]
646 + mouseClick(delegate, units.gu(3), y)

It's hard to understand what this is doing. Please make a function for it too.

669 + // TODO: Is there a better way to click on toolbar actions?

They have an object name, don't they? That's how we click them in autopilot tests.

I love the three tests in NotesPage. Thank you very much. This looks great for me. I don't fully understand some of the cpp statements, but they look simple enough.

Thanks for the review, will fix the issues. It seems there's an issue with Jenkins though :/ Leo, can you help me out there? I found a bug which might be related to this: https://bugs.launchpad.net/ubuntu/+source/llvm-toolchain-snapshot/+bug/1389729

FAILED: Continuous integration, rev:297
http://91.189.93.70:8080/job/reminders-app-ci/730/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2401/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/332/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/152/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/730/rebuild

CI have a card for this which they're tracking.
https://trello.com/c/2f8qfYun/87-vanguard-reminders-app-ci-failures-due-to-https-bugs-launchpad-net-ubuntu-source-llvm-toolchain-snapshot-bug-1389729
No solution proposed though.

#blocked on https://bugs.launchpad.net/ubuntu/+source/llvm-toolchain-snapshot/+bug/1389729

FAILED: Continuous integration, rev:297
http://91.189.93.70:8080/job/reminders-app-ci/775/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/197/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/775/rebuild

Text conflict in CMakeLists.txt
Text conflict in src/app/qml/Reminders.qml
Text conflict in src/app/qml/ui/EditNoteView.qml
3 conflicts encountered.
bzr: ERROR: Conflicts from merge

FAILED: Continuous integration, rev:298
http://91.189.93.70:8080/job/reminders-app-ci/776/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/198/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/776/rebuild

This needs the vivid overlay ppa added to the job in order to pass. Working on it.

FAILED: Continuous integration, rev:298
http://91.189.93.70:8080/job/reminders-app-ci/777/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/199/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/777/rebuild

FAILED: Continuous integration, rev:298
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/19/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/93/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/19/rebuild

Bah, this should work now, but:

Merging 'lp:reminders-app' in to 'build_dir'.
Text conflict in src/app/qml/components/NoteHeader.qml
Text conflict in src/app/qml/components/SortingDialog.qml

> Bah, this should work now, but:
>
> Merging 'lp:reminders-app' in to 'build_dir'.
> Text conflict in src/app/qml/components/NoteHeader.qml
> Text conflict in src/app/qml/components/SortingDialog.qml

merged

FAILED: Continuous integration, rev:299
http://91.189.93.70:8080/job/reminders-app-ci/794/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/216/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/794/rebuild

FAILED: Continuous integration, rev:300
http://91.189.93.70:8080/job/reminders-app-ci/795/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/217/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/795/rebuild

Adding the dependency and rebuilding.

PASSED: Continuous integration, rev:298
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/20/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/103/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/20/rebuild

PASSED: Continuous integration, rev:300
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/27/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/110/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/27/rebuild

Approving these :-)

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/469/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-autolanding/191/console

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/4/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/110/console

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/470/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-autolanding/192/console

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/6/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/112/console

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/471/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-autolanding/193/console

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/8/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/114/console

PASSED: Continuous integration, rev:300
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/28/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/112/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/28/rebuild

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/472/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-autolanding/194/console

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/12/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/118/console

Stupid old bot stopping the merge . .. grr...

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/473/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-autolanding/195/console

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/15/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/121/console

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/474/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-autolanding/196/console

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/19/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/126/console

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/19/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/127/console
    FAILURE: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/126/console

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/19/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/128/console
    FAILURE: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/127/console
    FAILURE: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/126/console

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/reminders-app-autolanding/475/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-autolanding/197/console

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/21/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/131/console

PASSED: Continuous integration, rev:300
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/29/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/119/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/29/rebuild

This is merged already...

DEBUG: Merging lp:~mzanetti/reminders-app/qmltest2 to lp:reminders-app
Traceback (most recent call last):
  File "/usr/bin/autoland", line 9, in <module>
    load_entry_point('jenkins-launchpad-plugin==0.1', 'console_scripts', 'autoland')()
  File "/usr/lib/python2.7/dist-packages/jlp/commands/autoland.py", line 262, in autoland
    ret = merge_and_commit(mp, args)
  File "/usr/lib/python2.7/dist-packages/jlp/commands/autoland.py", line 101, in merge_and_commit
    target.merge(source, str(mp.reviewed_revid))
  File "/usr/lib/python2.7/dist-packages/tarmac/branch.py", line 118, in merge
    branch.bzr_branch, to_revision=revid)
  File "<string>", line 4, in merge_from_branch_write_locked
  File "/usr/lib/python2.7/dist-packages/bzrlib/workingtree.py", line 807, in merge_from_branch
    raise errors.PointlessMerge
bzrlib.errors.PointlessMerge: Nothing to merge.