Ubuntu Notes app

Merge lp://qastaging/~mzanetti/reminders-app/qmltest3 into lp://qastaging/reminders-app

  1. qmltest3
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Needs review
Proposed branch: lp://qastaging/~mzanetti/reminders-app/qmltest3
Merge into: lp://qastaging/reminders-app
Prerequisite: lp://qastaging/~mzanetti/reminders-app/qmltest2
Diff against target: 325 lines (+156/-14)
8 files modified
src/app/qml/components/EditTagsDialog.qml (+4/-0)
src/app/qml/components/ListItemWithActions.qml (+2/-0)
src/app/qml/components/NotebooksDelegate.qml (+3/-2)
src/app/qml/components/NotesDelegate.qml (+2/-0)
src/app/qml/ui/SetReminderPage.qml (+1/-0)
src/app/qml/ui/SetReminderView.qml (+3/-0)
tests/qml/RemindersTestCase.qml (+53/-0)
tests/qml/tst_NotesPage.qml (+88/-12)
To merge this branch: bzr merge lp://qastaging/~mzanetti/reminders-app/qmltest3
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Needs Fixing
Nicholas Skaggs (community) Needs Fixing
Riccardo Padovani Needs Information
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+253753@code.qastaging.launchpad.net

Commit message

add more tests for the NotePage

* setting/unsetting a reminder
* tagging/untagging a note

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:299
http://91.189.93.70:8080/job/reminders-app-ci/726/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2386/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-utopic-amd64-ci/328/console
    FAILURE: http://91.189.93.70:8080/job/reminders-app-vivid-amd64-ci/147/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/reminders-app-ci/726/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Thanks for working on this :-)

I left some comments inline - nothing wrong, but I'm not sure about some choices

review: Needs Information
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:299
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/26/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/109/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-ci/26/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/2/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/102/console

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Text conflict in debian/control
Text conflict in src/app/qml/components/EditTagsDialog.qml
Text conflict in src/app/qml/components/ListItemWithActions.qml

review: Needs Fixing
Reply
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/reminders-app-autolanding/259/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/378/console

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

299. By Michael Zanetti

add more tests for the NotePage

* setting/unsetting a reminder
* tagging/untagging a note

298. By Michael Zanetti

more build-deps update

297. By Michael Zanetti

update build-deps

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches