Ubuntu Settings Components

Merge lp://qastaging/~mzanetti/ubuntu-settings-components/dpr into lp://qastaging/~registry/ubuntu-settings-components/trunk

  1. dpr
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Nick Dedekind
Approved revision: 86
Merged at revision: 92
Proposed branch: lp://qastaging/~mzanetti/ubuntu-settings-components/dpr
Merge into: lp://qastaging/~registry/ubuntu-settings-components/trunk
Diff against target: 13 lines (+2/-2)
1 file modified
Ubuntu/Settings/Menus/StandardMenu.qml (+2/-2)
To merge this branch: bzr merge lp://qastaging/~mzanetti/ubuntu-settings-components/dpr
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Andrea Cimitan Pending
Review via email: mp+253944@code.qastaging.launchpad.net

Commit message

Tell the layout what size we want the icons to be

width/height are ignored by the Layout and it uses only implicitWidth/implicitHeight unless explicitly set with Layout.preferredWidth/preferredHeight.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.

no

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

 * If you changed the UI, has there been a design review?

n/a

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:86
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/103/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-vivid/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-amd64-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/10/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/103/rebuild

review: Approve (continuous-integration)
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Looks fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: