Unity 8

Merge lp://qastaging/~mzanetti/unity8/drop-crossfadeimage into lp://qastaging/unity8

  1. drop-crossfadeimage
  2. Merge into trunk
Proposed by Michael Zanetti
Status: Merged
Approved by: Michał Sawicz
Approved revision: 337
Merged at revision: 343
Proposed branch: lp://qastaging/~mzanetti/unity8/drop-crossfadeimage
Merge into: lp://qastaging/unity8
Diff against target: 322 lines (+2/-278)
5 files modified
Components/CrossFadeImage.qml (+0/-151)
Greeter/GreeterContent.qml (+1/-1)
Shell.qml (+1/-0)
tests/qmltests/CMakeLists.txt (+0/-1)
tests/qmltests/Components/tst_CrossFadeImage.qml (+0/-125)
To merge this branch: bzr merge lp://qastaging/~mzanetti/unity8/drop-crossfadeimage
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+187229@code.qastaging.launchpad.net

Commit message

drop our CrossFadeImage in favor of the SDK one.

To post a comment you must log in.
lp://qastaging/~mzanetti/unity8/drop-crossfadeimage updated
337. By Michael Zanetti

debug--

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:337
http://jenkins.qa.ubuntu.com/job/unity8-ci/1096/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3923
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1501
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/1836
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/120
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1097
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1097/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/1096
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/254
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3985
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3985/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1503
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1503/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1271
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1281

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity8-ci/1096/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Is the "fadeInFirst" removal expected? Does it not affect the visuals?

review: Needs Information
Revision history for this message
Michael Zanetti (mzanetti) wrote :

> Is the "fadeInFirst" removal expected? Does it not affect the visuals?

Not really used any more. the SDK component has it set to "false" which is what we want in Shell and Greeter. The only place where we needed it set to true was the dummy infographics pictures we don't use any more.

Actually I think it even fixes the weirdness we've seen in the Greeter autopilot tests ;)

Revision history for this message
Michał Sawicz (saviq) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches