Phatch

Merge lp://qastaging/~nadiana/phatch/phatch_logging into lp://qastaging/phatch

phatch_logging
Merge into trunk

Proposed by Nadia Alramli on 2010-03-11

Status:	Merged
Merged at revision:	not available
Proposed branch:	lp://qastaging/~nadiana/phatch/phatch_logging
Merge into:	lp://qastaging/phatch
Diff against target:	335 lines (+100/-48) 6 files modified phatch/actions/save.py (+1/-1) phatch/app.py (+12/-2) phatch/core/api.py (+75/-33) phatch/core/models.py (+2/-2) phatch/core/pil.py (+8/-9) tests/test_suite/phatchtools.py (+2/-1)
To merge this branch:	bzr merge lp://qastaging/~nadiana/phatch/phatch_logging
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Stani		2010-03-11	Needs Information on 2010-03-11
Review via email: mp+21192@code.qastaging.launchpad.net

Description of the change

I tested the changes on the errors I know of. Like the warning when the image type changes or attempting to delete tags from a PNG image. The result is much more unified and easier to parse now. I also ran the full acceptance test and got much less errors than before the change.
I think the changes can be merge now. But they may need more tests. I just ran out of test ideas.

Revision history for this message

Stani (stani) wrote on 2010-03-11:

I wait until 0.2.7 has been accepted in Debian.

"I also ran the full acceptance test and got much less errors than before the change."
Although that seems nice, I wonder why that is? Why would changing the logging system produce less errors? Can you be specific which errors are not reported anymore (or less reported)?

review: Needs Information

Revision history for this message

Nadia Alramli (nadiana) wrote on 2010-03-11:

>Although that seems nice, I wonder why that is? Why would changing the logging system produce less errors? Can you be specific which errors are not reported anymore (or less reported)?

That's because you can now specify the logging level of phatch. By changing the logging level to errors only I got rid of all warnings that are being counted as errors. This can be improved even more once parsing error logs is implemented so instead of getting 50 errors about the same thing you get one with a count.