Merge lp://qastaging/~naesten/bzr-bisect/683822-bisect-start-range-argument into lp://qastaging/bzr-bisect

Proposed by Samuel Bronson
Status: Needs review
Proposed branch: lp://qastaging/~naesten/bzr-bisect/683822-bisect-start-range-argument
Merge into: lp://qastaging/bzr-bisect
Diff against target: 252 lines (+99/-18)
2 files modified
cmds.py (+62/-18)
tests.py (+37/-0)
To merge this branch: bzr merge lp://qastaging/~naesten/bzr-bisect/683822-bisect-start-range-argument
Reviewer Review Type Date Requested Status
Bazaar Developers Pending
Review via email: mp+124565@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Samuel Bronson (naesten) wrote :

Unfortunately, it turns out that this doesn't match the convention used by "run" for the common case of finding when a problem was introduced :-(.

87. By Samuel Bronson

Roll back my test changes; later, I'll add some tests just for this.

88. By Samuel Bronson

Merge lp:~jeff-licquia/bzr-bisect/yesno

This gives "yes" and "no" equal standing again.

89. By Samuel Bronson

Reverse polarity of "start -r" and "run -r".

Now it matches the "run" commands's return-value handling.

90. By Samuel Bronson

Add a test for "bzr bisect run -r".

91. By Samuel Bronson

Add some debug output (mostly log-only).

Revision history for this message
Samuel Bronson (naesten) wrote :

> Unfortunately, it turns out that this doesn't match the convention used by
> "run" for the common case of finding when a problem was introduced :-(.

Okay, as of revision 89, I've matched the polarities here; now, it's the bulk of the tests that don't match ;-).

Unmerged revisions

91. By Samuel Bronson

Add some debug output (mostly log-only).

90. By Samuel Bronson

Add a test for "bzr bisect run -r".

89. By Samuel Bronson

Reverse polarity of "start -r" and "run -r".

Now it matches the "run" commands's return-value handling.

88. By Samuel Bronson

Merge lp:~jeff-licquia/bzr-bisect/yesno

This gives "yes" and "no" equal standing again.

87. By Samuel Bronson

Roll back my test changes; later, I'll add some tests just for this.

86. By Samuel Bronson

Implement the "-r revA..revB" syntax for "start" and "run" suggested in bug 683822.

Quite likely this is buggy, and none of the scenareos in the test suite (some of which I converted to this syntax) are complicated enough to show this: they all seem to start by setting the bisect range to cover all revisions on the branch.

More tests would be quite useful!

85. By Samuel Bronson

Cleanup option handling preperatory to implementing bug 683822.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: