Checkbox

Merge ~narahuang/checkbox/+git/checkbox-configure:add-kernel-failboot into ~checkbox-dev/checkbox/+git/checkbox-configure:master

  1. Git
  2. lp:~narahuang/checkbox/+git/checkbox-configure
  3. add-kernel-failboot
  4. Merge into master
Proposed by Nara Huang
Status: Merged
Approved by: Nara Huang
Approved revision: 44b4aec6abcd203dbbc85ecce1bdafd38b55c528
Merged at revision: 049eeeab445fd78e658c0744cb35ce416c96e608
Proposed branch: ~narahuang/checkbox/+git/checkbox-configure:add-kernel-failboot
Merge into: ~checkbox-dev/checkbox/+git/checkbox-configure:master
Diff against target: 12 lines (+1/-0)
1 file modified
checkbox-provider-template/units/test-plan.pxu.in (+1/-0)
Reviewer Review Type Date Requested Status
Kristin Chuang (community) Approve
Maciej Kisielewski (community) Needs Information
Review via email: mp+408443@code.qastaging.launchpad.net

Description of the change

Add com.canonical.certification::ubuntucore/kernel-failboot-.* to default test plan.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Is there any story behind this requirement you could share?

I may be wrong, but I think it would be better to include this test in the ubuntucore-manual TP that's in the plainbox-provider-checkbox.

review: Needs Information
Revision history for this message
Nara Huang (narahuang) wrote :

Hello, the kernel-failboot test needs specific kernel branch to do the test, which needs HWE to open those branches in IoT kernel snaps, will only exist in our commercial iot project, so I think it's better to put the test here.

Revision history for this message
Kristin Chuang (kristinchuang) wrote :

Thanks Nara!

One suggestion - Do you think it makes sense to also add a comment "#keep if kernel snap is not pc-kernel" to the end of the line you added?

This way people will know that the case is not required for projects using pc-kernel snap (at least for now).

review: Needs Fixing
Revision history for this message
Kristin Chuang (kristinchuang) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches