Merge lp://qastaging/~nathandyer/midori/midori-extension-instapaper into lp://qastaging/midori
Proposed by
Nathan Dyer
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~nathandyer/midori/midori-extension-instapaper |
| Merge into: | lp://qastaging/midori |
| Diff against target: |
310 lines (+292/-0) 3 files modified
extensions/instapaper.vala (+70/-0) icons/CMakeLists.txt (+2/-0) icons/scalable/status/instapaper.svg (+220/-0) |
| To merge this branch: | bzr merge lp://qastaging/~nathandyer/midori/midori-extension-instapaper |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| gue5t gue5t | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
A new extension that allows users to save a web page to their Instapaper account (https:/
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Rather than setting the browser's URI property, JavaScript should be run in the context of the current tab. Under WK1 this context should be available via something like `view.get_
That said, it might be even better if we could do this with native code rather than any Javascript. What does the JS string do, is it actually your own work licensed under the LGPL, and how do we know the script it downloads from www.instapaper.com isn't going to change suddenly, breaking released versions of Midori? If Instapaper has an RPC API, it would be better to directly make an HTTP request against that.