Merge lp://qastaging/~nathandyer/midori/midori-extension-pocket into lp://qastaging/midori
Proposed by
Nathan Dyer
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~nathandyer/midori/midori-extension-pocket |
| Merge into: | lp://qastaging/midori |
| Diff against target: |
615 lines (+592/-0) 4 files modified
extensions/pocket.vala (+122/-0) icons/CMakeLists.txt (+2/-0) icons/scalable/status/pocket-grey.svg (+230/-0) icons/scalable/status/pocket-red.svg (+238/-0) |
| To merge this branch: | bzr merge lp://qastaging/~nathandyer/midori/midori-extension-pocket |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| gue5t gue5t | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
A new extension that allows users to save web articles, videos, and other content into their Pocket account (https:/
To post a comment you must log in.
Unmerged revisions
- 7087. By Nathan Dyer <email address hidden>
-
Initial commit for the Midori Pocket extension.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Similar comments apply as to the Instapaper extension: javascript should be run through contexts rather than setting browser URI; it would be ideal to do this natively, if possible; and we shouldn't be checking obfuscated javascript code which is likely copyrighted into the repository.
From a code style perspective, it might be better to have an active/inactive gicon value stored in the extension itself rather than creating new GLib.ThemedIcon instances with string names throughout the code.
It would also be a good idea to link the website of this service in the extension description, since many users will not be on a first-name basis with "Pocket".