Do Plugins

Merge lp://qastaging/~neal-s/do-plugins/firefoxawesomebar into lp://qastaging/do-plugins

  1. firefoxawesomebar
  2. Merge into trunk
Proposed by Neal Stewart
Status: Superseded
Proposed branch: lp://qastaging/~neal-s/do-plugins/firefoxawesomebar
Merge into: lp://qastaging/do-plugins
Diff against target: None lines
To merge this branch: bzr merge lp://qastaging/~neal-s/do-plugins/firefoxawesomebar
Reviewer Review Type Date Requested Status
Do Plugins Team Pending
Review via email: mp+5462@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2009-04-18.

To post a comment you must log in.
Revision history for this message
Neal Stewart (neal-s) wrote :

Another try!

This version allows you to search through your Firefox Bookmarks from Gnome Do directly.

Bookmarks and History are both provided as children of the Firefox Application.

Revision history for this message
Neal Stewart (neal-s) wrote :

Code reverted to old version somehow? Will fix in a few hours. Delay review, please.

> Another try!
>
> This version allows you to search through your Firefox Bookmarks from Gnome Do
> directly.
>
> Bookmarks and History are both provided as children of the Firefox
> Application.

lp://qastaging/~neal-s/do-plugins/firefoxawesomebar updated
591. By Neal Stewart <email address hidden>

Reverted back to where it should have been. See last revision for what's
actually in here.

Revision history for this message
Neal Stewart (neal-s) wrote :

And now it's back to where it was this afternoon.

lp://qastaging/~neal-s/do-plugins/firefoxawesomebar updated
592. By Neal Stewart <email address hidden>

Cleaned house a little.

593. By Neal Stewart <email address hidden>

Added some comments, took out some unnecessary logic.

Removed filtering on empty titles. Now, if a title is empty the place is put
in with url as title.

594. By Neal Stewart <email address hidden>

FUNCTION CHANGES -----

Created BrowseBookmarkItem and BrowseHistoryItem.
ChildrenOfItems given for both. Provide what you'd expect.

Feeding Main Firefox application those items.

Firefox Awesome Bar item provides those items, as well as Bookmarks, to
the main list.

See ChildrenOfItem in FABarItemSource for details.

FORMAT CHANGES -----

Now complying to Mono standards in method calls and parameters.

Instantiated SQlite search results to provide code clarity.

Changed connection string creation from string literal to concatenated
string.

595. By Neal Stewart <email address hidden>

Hopefully fixed the SQL formatting problems with Loggerhead...hopefully.

596. By Neal Stewart <email address hidden>

Changed some method names.

597. By Neal Stewart <email address hidden>

fixins

598. By Neal Stewart <email address hidden>

Changed Collection searching to LINQ

Some housekeeping.

599. By Neal Stewart <email address hidden>

Removed Path.Combine(Path.Combine...

Now using Linq.

600. By Neal Stewart <email address hidden>

Changed from Community to Official.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Firefox/Firefox.mdp'
2--- Firefox/Firefox.mdp 2009-02-28 16:16:48 +0000
3+++ Firefox/Firefox.mdp 2009-04-11 17:26:50 +0000
4@@ -18,12 +18,17 @@
5 <File name="src" subtype="Directory" buildaction="Compile" />
6 <File name="src/BookmarkItemSource.cs" subtype="Code" buildaction="Compile" />
7 <File name="Resources/Firefox.addin.xml" subtype="Code" buildaction="EmbedAsResource" />
8+ <File name="src/FABarItemSource.cs" subtype="Code" buildaction="Compile" />
9+ <File name="src/FABarItems.cs" subtype="Code" buildaction="Compile" />
10 </Contents>
11 <References>
12 <ProjectReference type="Gac" localcopy="True" refto="System, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />
13 <ProjectReference type="Gac" localcopy="True" refto="Mono.Posix, Version=2.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756" />
14- <ProjectReference type="Gac" localcopy="True" refto="Do.Platform, Version=0.8.0.0, Culture=neutral, PublicKeyToken=null" />
15- <ProjectReference type="Gac" localcopy="True" refto="Do.Universe, Version=0.8.0.0, Culture=neutral, PublicKeyToken=null" />
16 <ProjectReference type="Gac" localcopy="True" refto="System.Core, Version=3.5.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />
17+ <ProjectReference type="Gac" localcopy="True" refto="System.Data, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />
18+ <ProjectReference type="Gac" localcopy="True" refto="Mono.Data.SqliteClient, Version=2.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756" />
19+ <ProjectReference type="Gac" localcopy="True" refto="Do.Platform, Version=0.9.0.0, Culture=neutral, PublicKeyToken=null" />
20+ <ProjectReference type="Gac" localcopy="True" refto="Do.Platform.Linux, Version=0.9.0.0, Culture=neutral, PublicKeyToken=null" />
21+ <ProjectReference type="Gac" localcopy="True" refto="Do.Universe, Version=0.9.0.0, Culture=neutral, PublicKeyToken=null" />
22 </References>
23 </Project>
24\ No newline at end of file
25
26=== modified file 'Firefox/Makefile.am'
27--- Firefox/Makefile.am 2009-01-09 05:04:13 +0000
28+++ Firefox/Makefile.am 2009-04-11 17:26:50 +0000
29@@ -3,7 +3,8 @@
30 ASSEMBLY=Firefox
31
32 FILES = \
33- src/BookmarkItemSource.cs
34+ src/FABarItemSource.cs \
35+ src/FABarItems.cs
36
37 RESOURCES = \
38 Resources/Firefox.addin.xml
39@@ -12,5 +13,7 @@
40 Mono.Posix \
41 System \
42 System.Core \
43+ System.Data \
44+ Mono.Data.SqliteClient \
45 $(DO_PLATFORM_LIBS) \
46 $(DO_UNIVERSE_LIBS)
47
48=== modified file 'Firefox/Resources/Firefox.addin.xml'
49--- Firefox/Resources/Firefox.addin.xml 2009-01-16 23:29:46 +0000
50+++ Firefox/Resources/Firefox.addin.xml 2009-04-11 17:26:50 +0000
51@@ -1,11 +1,11 @@
52 <Addin
53 id="Firefox"
54 namespace="Do"
55- version="2.2"
56+ version="3"
57 name="Firefox"
58- description="Search Firefox 3 bookmarks."
59- author="David Siegel"
60- category="Official"
61+ description="Search Firefox 3 bookmarks, bookmark directories, and history."
62+ author="Neal Stewart"
63+ category="Community"
64 >
65
66 <Runtime>
67@@ -17,6 +17,6 @@
68 </Dependencies>
69
70 <Extension path="/Do/ItemSource">
71- <ItemSource type="Mozilla.Firefox.BookmarkItemSource" />
72+ <ItemSource type="Mozilla.Firefox.FABarItemSource" />
73 </Extension>
74 </Addin>

Subscribers

People subscribed via source and target branches