Mixxx

Merge lp://qastaging/~neale/mixxx/m4a into lp://qastaging/~mixxxdevelopers/mixxx/trunk

m4a
Merge into trunk

Proposed by Neale Pickett on 2012-08-25

Status:	Needs review
Proposed branch:	lp://qastaging/~neale/mixxx/m4a
Merge into:	lp://qastaging/~mixxxdevelopers/mixxx/trunk
Diff against target:	1832 lines (+338/-1341) 9 files modified mixxx/build/features.py (+5/-10) mixxx/plugins/soundsourcem4a/SConscript (+1/-8) mixxx/plugins/soundsourcem4a/m4a/comment.h (+0/-30) mixxx/plugins/soundsourcem4a/m4a/ip.h (+0/-99) mixxx/plugins/soundsourcem4a/m4a/mp4-mixxx.cpp (+0/-587) mixxx/plugins/soundsourcem4a/m4a/mp4.c (+0/-407) mixxx/plugins/soundsourcem4a/m4a/sf.h (+0/-61) mixxx/plugins/soundsourcem4a/soundsourcem4a.cpp (+316/-129) mixxx/plugins/soundsourcem4a/soundsourcem4a.h (+16/-10)
To merge this branch:	bzr merge lp://qastaging/~neale/mixxx/m4a
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Stefan Nürnberger (community)		Needs Information on 2013-04-04
RJ Skerry-Ryan	2012-08-25	Pending
Review via email: mp+121310@code.qastaging.launchpad.net

Description of the change

Rewritten M4A plugin, uses libmp4ff instead of libmp4v2. Works with all my M4A files, and I will maintain the code if people can send me examples of problem files.

Revision history for this message

Stefan Nürnberger (kabelfrickler) wrote on 2013-04-04:

As the faad2 developers mention, mp4ff is not meant as a library for external programs like Mixxx. They do not ship the library by default anymore, resulting in quite some bug reports about broken dependencies. See e.g. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=550679#57

Quote:
"again, libmp4ff was never meant to be used outside of faad2 and its
use is explicitely discouraged upstream and we deeply regret having
shipped it at all. Please get your application fixed to use mp4v2
instead (if it is MPL-compatible) or ffmpeg (prefered)."

I therefore propose to keep the old implementation using mp4v2. What is/was the reason for using mp4ff instead, anyway?

review: Needs Information

Revision history for this message

Neale Pickett (neale) wrote on 2013-04-04:

> I therefore propose to keep the old implementation using mp4v2. What is/was
> the reason for using mp4ff instead, anyway?

Yeah, it should use mp4v2.

The reason I moved to mp4ff is because I couldn't find example code for mp4v2. The original motivation for this branch was that I have a whole lot of m4a files with frames larger than the current implementation can handle.

I'll port this branch to mp4v2 and submit another merge request when that work is done. The main thing this patch does is make mixxx work with all m4a files I can find, the container parsing library isn't significant.