Ubuntu Settings Components

Merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/access-point-init into lp://qastaging/~registry/ubuntu-settings-components/trunk

  1. access-point-init
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 67
Merged at revision: 67
Proposed branch: lp://qastaging/~nick-dedekind/ubuntu-settings-components/access-point-init
Merge into: lp://qastaging/~registry/ubuntu-settings-components/trunk
Diff against target: 35 lines (+15/-0)
2 files modified
Ubuntu/Settings/Menus/AccessPointMenu.qml (+8/-0)
tests/qmltests/Menus/tst_AccessPointMenu.qml (+7/-0)
To merge this branch: bzr merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/access-point-init
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+212913@code.qastaging.launchpad.net

Commit message

Fixed issue with Access Point checkbox not fetching initial value.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
no

* Did you perform an exploratory manual test run of your code change and any related functionality?
yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
no

* If you changed the UI, has there been a design review?
N/a

To post a comment you must log in.
lp://qastaging/~nick-dedekind/ubuntu-settings-components/access-point-init updated
67. By Nick Dedekind

Added comment

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:67
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/37/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-trusty/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-trusty-amd64-ci/17
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-trusty-armhf-ci/17

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/37/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

is there a chance we're clearing enableCheckConnection value? (something setting this before the Component.onCompleted) do we need the oldValue here as well?

review: Needs Information
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> is there a chance we're clearing enableCheckConnection value? (something
> setting this before the Component.onCompleted) do we need the oldValue here as
> well?

Nope. Component.onCompleted cannot be called as a result of any other function calls in this component. As enableCheckConnection is always returned to it's previous value, this will always be true at the start of Component.onCompleted

Revision history for this message
Andrea Cimitan (cimi) wrote :

After long private discussion, it's fine for now :) Thank you

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: