Ubuntu Settings Components

Merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/calendar-freeze into lp://qastaging/ubuntu-settings-components

  1. calendar-freeze
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Michał Sawicz
Approved revision: 124
Merged at revision: 149
Proposed branch: lp://qastaging/~nick-dedekind/ubuntu-settings-components/calendar-freeze
Merge into: lp://qastaging/ubuntu-settings-components
Diff against target: 521 lines (+209/-154)
4 files modified
plugins/Ubuntu/Settings/Components/Calendar.js (+100/-0)
plugins/Ubuntu/Settings/Components/Calendar.qml (+104/-102)
plugins/Ubuntu/Settings/Components/dateExt.js (+0/-48)
tests/qmltests/Components/tst_Calendar.qml (+5/-4)
To merge this branch: bzr merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/calendar-freeze
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Pending
Lukáš Tinkl Pending
Review via email: mp+296297@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2016-03-30.

Commit message

Removed some of the timezone sensitive date code from calendar

Description of the change

Removed some of the timezone sensitive date code from calendar

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:124
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/28/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1193
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1170
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1170
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1168
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1168/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1168
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1168/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1168
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1168/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1168
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1168/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1168
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1168/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1168
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1168/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/28/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:124
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/150/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-vivid/75
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-amd64-ci/57
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/57
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/57/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/150/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote : Posted in a previous version of this proposal

Works fine, no more freezes after changing TZ and triggering a redraw of the component.

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:124
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/31/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/1822/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1851/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/31/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:124
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/33/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/1837/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1863/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/33/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:124
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/39/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/1992/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2020/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/39/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: