Ubuntu Settings Components

Merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/indicator-polishing into lp://qastaging/~registry/ubuntu-settings-components/trunk

  1. indicator-polishing
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 108
Merged at revision: 78
Proposed branch: lp://qastaging/~nick-dedekind/ubuntu-settings-components/indicator-polishing
Merge into: lp://qastaging/~registry/ubuntu-settings-components/trunk
Prerequisite: lp://qastaging/~nick-dedekind/ubuntu-settings-components/uqmlscene
Diff against target: 4066 lines (+1369/-1495)
58 files modified
CMakeLists.txt (+1/-0)
Ubuntu/Settings/Components/ActionTextField.qml (+35/-33)
Ubuntu/Settings/Components/CMakeLists.txt (+0/-2)
Ubuntu/Settings/Components/Calendar.qml (+2/-2)
Ubuntu/Settings/Components/IconVisual.qml (+0/-71)
Ubuntu/Settings/Components/MessageHeader.qml (+104/-134)
Ubuntu/Settings/Components/QuickReply.qml (+4/-4)
Ubuntu/Settings/Components/UbuntuShapeForItem.qml (+43/-0)
Ubuntu/Settings/Components/artwork/CMakeLists.txt (+0/-2)
Ubuntu/Settings/Components/qmldir (+2/-2)
Ubuntu/Settings/Menus/AccessPointMenu.qml (+14/-76)
Ubuntu/Settings/Menus/ButtonMenu.qml (+15/-13)
Ubuntu/Settings/Menus/CMakeLists.txt (+0/-2)
Ubuntu/Settings/Menus/CalendarMenu.qml (+3/-4)
Ubuntu/Settings/Menus/CheckableMenu.qml (+5/-13)
Ubuntu/Settings/Menus/EventMenu.qml (+9/-9)
Ubuntu/Settings/Menus/GroupedMessageMenu.qml (+28/-32)
Ubuntu/Settings/Menus/MediaPlayerMenu.qml (+39/-29)
Ubuntu/Settings/Menus/PlaybackItemMenu.qml (+53/-44)
Ubuntu/Settings/Menus/ProgressBarMenu.qml (+20/-12)
Ubuntu/Settings/Menus/ProgressValueMenu.qml (+9/-8)
Ubuntu/Settings/Menus/SectionMenu.qml (+2/-2)
Ubuntu/Settings/Menus/SeparatorMenu.qml (+3/-7)
Ubuntu/Settings/Menus/SimpleMessageMenu.qml (+66/-49)
Ubuntu/Settings/Menus/SimpleTextMessageMenu.qml (+0/-99)
Ubuntu/Settings/Menus/SliderMenu.qml (+6/-7)
Ubuntu/Settings/Menus/SnapDecisionMenu.qml (+64/-126)
Ubuntu/Settings/Menus/StandardMenu.qml (+24/-8)
Ubuntu/Settings/Menus/SwitchMenu.qml (+38/-37)
Ubuntu/Settings/Menus/TextMessageMenu.qml (+3/-4)
Ubuntu/Settings/Menus/TimeZoneMenu.qml (+10/-7)
Ubuntu/Settings/Menus/TransferMenu.qml (+24/-18)
Ubuntu/Settings/Menus/UserSessionMenu.qml (+28/-19)
Ubuntu/Settings/Menus/artwork/CMakeLists.txt (+0/-2)
Ubuntu/Settings/Menus/artwork/default_app.svg (+0/-42)
Ubuntu/Settings/Menus/artwork/secure.svg (+0/-71)
Ubuntu/Settings/Menus/qmldir (+1/-3)
debian/changelog (+8/-0)
debian/control (+2/-2)
examples/CMakeLists.txt (+2/-0)
examples/MessageComponents.qml (+119/-0)
examples/OtherComponents.qml (+237/-0)
examples/SettingsComponents.qml (+29/-254)
examples/TransferComponents.qml (+84/-0)
runtests.sh (+2/-2)
tests/qmltests/CMakeLists.txt (+3/-2)
tests/qmltests/Menus/tst_AccessPointMenu.qml (+3/-21)
tests/qmltests/Menus/tst_ButtonMenu.qml (+1/-1)
tests/qmltests/Menus/tst_CheckableMenu.qml (+2/-2)
tests/qmltests/Menus/tst_EventMenu.qml (+1/-1)
tests/qmltests/Menus/tst_GroupedMessageMenu.qml (+1/-1)
tests/qmltests/Menus/tst_MediaPlayerMenu.qml (+10/-10)
tests/qmltests/Menus/tst_PlaybackItemMenu.qml (+1/-1)
tests/qmltests/Menus/tst_SimpleMessageMenu.qml (+57/-50)
tests/qmltests/Menus/tst_SnapDecisionMenu.qml (+82/-95)
tests/qmltests/Menus/tst_SwitchMenu.qml (+2/-2)
tests/qmltests/Menus/tst_TextMessageMenu.qml (+67/-57)
tests/utils/modules/Ubuntu/Test/UbuntuTestCase.qml (+1/-1)
To merge this branch: bzr merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/indicator-polishing
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
Albert Astals Cid (community) Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Zanetti (community) Needs Fixing
Review via email: mp+229083@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-07-29.

Description of the change

Visual changes for indicator RTM polishing sprint

https://docs.google.com/a/canonical.com/document/d/1KC40suUs13gajIlE1Ms6PJYoIPx_AjlF4ae6bvtNjNc/edit

 * Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~nick-dedekind/unity8/indicator-polishing/+merge/228700

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the UI, has there been a design review?
Yes

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:79
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/65/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/23/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/27

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/65/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:81
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/66/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/24/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/28/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/28/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/66/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:85
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/67/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/25/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/29/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/29/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/67/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:88
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/68/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/26/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/30

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/68/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

jenkins failing due to lacking xvfb-run

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:89
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/71/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/29/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/33

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/71/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/73/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/35

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/73/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:91
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/75/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/33/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/37

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/75/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

Some comments, as well as I'd bump qt quick requirements to 2.2 on the files touched, and Ubuntu Components 1.1

review: Needs Fixing
Revision history for this message
Andrea Cimitan (cimi) wrote :

- Some listitems in the example qml have different highlight on press:
User account with lola chang, timezone one

- Status icon at the bottom doesn't seem to have padding or right size

- press effect on buttons seems a bit weird, like it changes size and font size

review: Needs Fixing
Revision history for this message
Andrea Cimitan (cimi) wrote :

Do we want to animate expansions of message components?

Revision history for this message
Andrea Cimitan (cimi) wrote :

Also, that might be a different issue (SDK) but when I move the slider, sometimes I can flick between pages.. be sure we don't have this in unity8, and if it happens to be a bug in sdk, file it

Revision history for this message
Andrea Cimitan (cimi) wrote :

if you can, would be nice to not shorten variable names or ids, like using animation instead ani

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

comments attached.

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> - Some listitems in the example qml have different highlight on press:
> User account with lola chang, timezone one

Fixed. use StandardMenu now.

>
> - Status icon at the bottom doesn't seem to have padding or right size

The Status icons are just examples of their component usage. Not supposed to be padded.

>
> - press effect on buttons seems a bit weird, like it changes size and font
> size

This is sdk. Raise a bug if you think it's wrong.
Not sure which buttons you are talking about size and font. The ones in messaging are as designed (or defaulted in sdk). The other buttons are sized to text as in sdk

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> Do we want to animate expansions of message components?

Yes. I put this back.

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> Also, that might be a different issue (SDK) but when I move the slider,
> sometimes I can flick between pages.. be sure we don't have this in unity8,
> and if it happens to be a bug in sdk, file it

SDK bug it would seem.

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> if you can, would be nice to not shorten variable names or ids, like using
> animation instead ani

fixed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:92
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/77/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/39
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/39

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/77/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) :
review: Approve
Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
Yes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:97
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/80/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/38
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/42
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/42

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/80/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:98
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/81/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/39
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/43
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/43

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/81/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:99
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/82/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/40
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/44

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/82/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:100
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/83/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/41
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/45
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/45

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/83/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Breaks the indicators.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:103
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/84/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/42/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/46

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/84/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:104
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/85/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/43/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/47
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/47

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/85/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:105
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/86/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/44/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/48
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/48

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/86/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:107
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/87/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/45/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/49
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/49

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/87/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
No, seems unrelated

review: Approve
Revision history for this message
Albert Astals Cid (aacid) wrote :

Please add a i18n.tr to

./Ubuntu/Settings/Components/QuickReply.qml:63: text: "Quick reply with:"

And also who are people translating the strings marked with i18n here? Doesn't seem to be a .pot file :S

review: Needs Fixing
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> Please add a i18n.tr to
>
> ./Ubuntu/Settings/Components/QuickReply.qml:63: text: "Quick
> reply with:"

Done.

>
>
> And also who are people translating the strings marked with i18n here? Doesn't
> seem to be a .pot file :S

Hm. good point. I'll add it on another MP.

Revision history for this message
Andrea Cimitan (cimi) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: