Merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/lp1369737 into lp://qastaging/~registry/ubuntu-settings-components/trunk

Proposed by Nick Dedekind
Status: Merged
Approved by: Michał Sawicz
Approved revision: 81
Merged at revision: 80
Proposed branch: lp://qastaging/~nick-dedekind/ubuntu-settings-components/lp1369737
Merge into: lp://qastaging/~registry/ubuntu-settings-components/trunk
Diff against target: 16 lines (+2/-1)
1 file modified
Ubuntu/Settings/Components/ActionTextField.qml (+2/-1)
To merge this branch: bzr merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/lp1369737
Reviewer Review Type Date Requested Status
Michał Sawicz (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+238199@code.qastaging.launchpad.net

Commit message

Enable send button on input composition

Description of the change

Enable send button on input composition

* Are there any related MPs required for this MP to build/function as expected? Please list.
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Remember to do inputMethod.commit() before send.

review: Needs Fixing
81. By Nick Dedekind

commit before send

Revision history for this message
Michał Sawicz (saviq) wrote :

Yup, code looks fine. Will test out when jenkins comes up with packages.

review: Approve (code)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Kevin tested on silo.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: