Ubuntu Settings Components

Merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/standard-item-preferred-values into lp://qastaging/~registry/ubuntu-settings-components/trunk

  1. standard-item-preferred-values
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 88
Merged at revision: 91
Proposed branch: lp://qastaging/~nick-dedekind/ubuntu-settings-components/standard-item-preferred-values
Merge into: lp://qastaging/~registry/ubuntu-settings-components/trunk
Diff against target: 43 lines (+4/-7)
3 files modified
plugins/Ubuntu/Settings/Menus/GroupedMessageMenu.qml (+2/-2)
plugins/Ubuntu/Settings/Menus/StandardMenu.qml (+0/-3)
plugins/Ubuntu/Settings/Menus/UserSessionMenu.qml (+2/-2)
To merge this branch: bzr merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/standard-item-preferred-values
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+257871@code.qastaging.launchpad.net

Commit message

Don't use preferred values inside Standard item compoonent Loader.

Description of the change

Don't use preferred values inside Standard item compoonent Loader.

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:88
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/111/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-vivid/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-amd64-ci/18
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/18
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-vivid-armhf-ci/18/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/111/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: