Ubuntu Settings Components

Merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/transfer-menu into lp://qastaging/~registry/ubuntu-settings-components/trunk

  1. transfer-menu
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Michał Sawicz
Approved revision: 74
Merged at revision: 74
Proposed branch: lp://qastaging/~nick-dedekind/ubuntu-settings-components/transfer-menu
Merge into: lp://qastaging/~registry/ubuntu-settings-components/trunk
Prerequisite: lp://qastaging/~nick-dedekind/ubuntu-settings-components/menu.plugin
Diff against target: 374 lines (+304/-1)
8 files modified
SettingsComponents.qml (+19/-0)
Ubuntu/Settings/Menus/CMakeLists.txt (+1/-0)
Ubuntu/Settings/Menus/TransferMenu.qml (+96/-0)
Ubuntu/Settings/Menus/plugin.cpp (+6/-0)
Ubuntu/Settings/Menus/types.h (+43/-0)
debian/changelog (+2/-1)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/Menus/tst_TransferMenu.qml (+136/-0)
To merge this branch: bzr merge lp://qastaging/~nick-dedekind/ubuntu-settings-components/transfer-menu
Reviewer Review Type Date Requested Status
Michał Sawicz (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Andrea Cimitan (community) Needs Fixing
Review via email: mp+224672@code.qastaging.launchpad.net

Commit message

Added TransferMenu

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:68
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/52/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/14
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/14

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/52/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:69
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/54/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/16

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/54/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:70
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/56/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/18
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/18

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/56/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

I've asked Cimi to review this as he's a member of ubuntu-settings-components and I'm not; however, FWIW:

> * Did you perform an exploratory manual test run of the code change and any related functionality?

Yes.

Manual test conducted in conjunction with
https://code.launchpad.net/~nick-dedekind/ubuntu-settings-components/transfer-menu/+merge/224672 and https://code.launchpad.net/~charlesk/indicator-transfer/per-transfer-actions/+merge/224537. The manual tests in the indicator-transfer MP put these new transfer menu components on display.

> * Did CI run pass? If not, please explain why.

Yes.

Revision history for this message
Andrea Cimitan (cimi) wrote :

I'd test what should change with active: true or false (visibility).

review: Needs Fixing
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> I'd test what should change with active: true or false (visibility).

Done. & added stateText test

Revision history for this message
Michał Sawicz (saviq) wrote :

Bump changelog so we can depend on it?

More inline.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:71
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/62/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/24

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/62/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Oh and one more thing... Do (should) the enum values come from somewhere?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:72
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/63/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/25

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/63/rebuild

review: Approve (continuous-integration)
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Fixed review comments

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> Oh and one more thing... Do (should) the enum values come from somewhere?

They come from indicator-transfer
http://bazaar.launchpad.net/~charlesk/indicator-transfer/per-transfer-actions/view/head:/include/transfer/transfer.h

would need to do some shizzle in there if we wanted to export to includes.

Revision history for this message
Michał Sawicz (saviq) wrote :

> > Oh and one more thing... Do (should) the enum values come from somewhere?
>
> They come from indicator-transfer
> http://bazaar.launchpad.net/~charlesk/indicator-transfer/per-transfer-
> actions/view/head:/include/transfer/transfer.h
>
> would need to do some shizzle in there if we wanted to export to includes.

I'd just be worried that this get out of sync... There's probably no lib from the indicator that we could link to?

review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:73
http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-ci/64/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-qmltests-utopic/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-amd64-ci/26
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-settings-components-utopic-armhf-ci/26

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-settings-components-ci/64/rebuild

review: Approve (continuous-integration)
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> > > Oh and one more thing... Do (should) the enum values come from somewhere?
> >
> > They come from indicator-transfer
> > http://bazaar.launchpad.net/~charlesk/indicator-transfer/per-transfer-
> > actions/view/head:/include/transfer/transfer.h
> >
> > would need to do some shizzle in there if we wanted to export to includes.
>
> I'd just be worried that this get out of sync... There's probably no lib from
> the indicator that we could link to?

Not for the transfer indicator specifically. There's libindicator, but I don't think it's used for the indicators we use.

Revision history for this message
Michał Sawicz (saviq) wrote :

Yup.

review: Approve
lp://qastaging/~nick-dedekind/ubuntu-settings-components/transfer-menu updated
75. By Nick Dedekind

updated debian packaging

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: