Merge lp://qastaging/~nick-dedekind/ubuntu-system-settings/lp1336715.check.sync into lp://qastaging/ubuntu-system-settings

FAILED: Continuous integration, rev:1154
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1714/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6339
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4242
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/906
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5944
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7591
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7591/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15247
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3598
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4631
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4631/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1714/rebuild

FAILED: Continuous integration, rev:1156
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1718/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6354/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4246/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/910
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5958/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7606
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7606/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15263
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3602/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4638
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4638/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1718/rebuild

Thanks. That seems to change more than what the description says though (it has dialpad sound changes and wifi ui cleanings, those should probably be submitted as different changesets)

Could you also give some background informations on why we need a special Switch widget. Could the toolkit be updated/fixed in a way that would let us use the standard component (if the answer is yes, then we should open a bug report about that at least)

> Thanks. That seems to change more than what the description says though (it
> has dialpad sound changes and wifi ui cleanings, those should probably be
> submitted as different changesets)

Pushed the wifi ui cleanup to the wrong branch by mistake; they are already in a different branch.
I changed the wifi switch to use the usc component because there were problems with the switch menu that were fixed in usc.
The dialpad sound changes I'm not seeing (other than fixing the sync issue).

>
> Could you also give some background informations on why we need a special
> Switch widget. Could the toolkit be updated/fixed in a way that would let us
> use the standard component (if the answer is yes, then we should open a bug
> report about that at least)

The problem is not an issue with the sdk. It's how we use it with qml. We are assuming that we can just bind the 'check' property to another property value and everything will be fine.
If we want to do it without a special component which handles the broken binding, we have to do something like:

Switch {
   property bool serverChecked: settings.spellChecking
   onServerCheckedChanged: check = serverChecked
   Component.onCompleted: check = serverChecked
   onClicked: settings.spellChecking = checked
}

for every use; which in retrospect doesn't look horrific as I though. Let me know if you'd rather have it this way and I'll make the change.

Thanks, I don't have a strong preference on the component choice, though it seems nicer to use the uitk widget if possible (less external depends, code easier to understand for people who don't know the settings components)

the change look fine on principle to me, some extra questions/comments:

- is ubuntu-settings-component 0.5 lined up for landing yet? (what changed in that version that you require it)

- why do you use "Component.onCompleted: clicked.connect" in some cases and not others?

- you have merge conflicts, those should be resolved

> Thanks, I don't have a strong preference on the component choice, though it
> seems nicer to use the uitk widget if possible (less external depends, code
> easier to understand for people who don't know the settings components)

I might change to use the uitk without using bindings then. Just need to ensure that i've covered all the bases.

>
> the change look fine on principle to me, some extra questions/comments:
>
> - is ubuntu-settings-component 0.5 lined up for landing yet? (what changed in
> that version that you require it)

https://code.launchpad.net/~nick-dedekind/ubuntu-settings-components/lp1336715.check.sync/+merge/239491

Added the SyncCheckBox which is currently a requirement for this branch. If I remove it and use the base sdk component, I'll remove the version requirement.

>
> - why do you use "Component.onCompleted: clicked.connect" in some cases and
> not others?

If a Loader is used, then we need to connect the click of the list item to the loader item (since the ListItem.control is getting the click, rather than the Loader.item.

>
> - you have merge conflicts, those should be resolved

Will do.

> Thanks, I don't have a strong preference on the component choice, though it
> seems nicer to use the uitk widget if possible (less external depends, code
> easier to understand for people who don't know the settings components)
>

I've removed the extra component. Doesn't require any new components now; just fixes for existing Switches/CheckBoxes.

I'd REALLY like to add tests for all the switches/checks.
But will be a bit of an undertaking...

FAILED: Continuous integration, rev:1160
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1725/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6450
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4279/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/917
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/6050
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7702
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7702/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15407
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3632/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4673
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4673/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1725/rebuild

You have some spacing changes in SingleSim, could you revert those? Otherwise looks good, approving once those are resolved

Thanks, looks good.

The white space fixes are in https://code.launchpad.net/~unity-team/ubuntu-system-settings/lp1336715.check.sync/+merge/240775

Thanks!