Merge lp://qastaging/~nick-dedekind/ubuntu-ui-toolkit/actionItem-mnemonics into lp://qastaging/ubuntu-ui-toolkit/staging
Proposed by
Nick Dedekind
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~nick-dedekind/ubuntu-ui-toolkit/actionItem-mnemonics |
| Merge into: | lp://qastaging/ubuntu-ui-toolkit/staging |
| Diff against target: |
740 lines (+319/-97) 8 files modified
components.api (+8/-1) src/UbuntuToolkit/ubuntutoolkitmodule.cpp (+2/-0) src/UbuntuToolkit/ucaction.cpp (+1/-77) src/UbuntuToolkit/ucaction_p.h (+2/-1) src/UbuntuToolkit/ucactionitem.cpp (+249/-17) src/UbuntuToolkit/ucactionitem_p.h (+44/-0) src/UbuntuToolkit/ucactionitem_p_p.h (+4/-0) tests/unit/visual/tst_actionitem.11.qml (+9/-1) |
| To merge this branch: | bzr merge lp://qastaging/~nick-dedekind/ubuntu-ui-toolkit/actionItem-mnemonics |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Zsombor Egri | Needs Information | ||
|
Review via email:
|
|||
Commit message
Moved Action mnemonic logic to the ActionItem.
Description of the change
Moved Action mnemonic logic to the ActionItem.
Added ActionItem.mnemonic for altering properties of the mnemonic logic.
To post a comment you must log in.
Unmerged revisions
- 1331. By Nick Dedekind
-
Added mnemonic type
- 1330. By Nick Dedekind
-
removed extra coment block end
- 1329. By Nick Dedekind
-
removed action check
- 1328. By Nick Dedekind
-
merged with staging
- 1327. By Nick Dedekind
-
merged with trunk
- 1326. By Nick Dedekind
-
added qdoc check
- 1325. By Nick Dedekind
-
fixed 1.3 version of ActionItem
- 1324. By Nick Dedekind
-
merged with staging
- 1323. By Nick Dedekind
-
API fixes
- 1322. By Nick Dedekind
-
Added mnemonic test
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Mostly clarification I need. Also few more tests to cover the group properties please.