Ubuntu UI Toolkit

Merge lp://qastaging/~nick-dedekind/ubuntu-ui-toolkit/prevent-slider-mouse-stealing into lp://qastaging/ubuntu-ui-toolkit

  1. prevent-slider-mouse-stealing
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Work in progress
Proposed branch: lp://qastaging/~nick-dedekind/ubuntu-ui-toolkit/prevent-slider-mouse-stealing
Merge into: lp://qastaging/ubuntu-ui-toolkit
Diff against target: 135 lines (+35/-25)
2 files modified
modules/Ubuntu/Components/Slider.qml (+2/-20)
tests/unit_x11/tst_components/tst_slider.qml (+33/-5)
To merge this branch: bzr merge lp://qastaging/~nick-dedekind/ubuntu-ui-toolkit/prevent-slider-mouse-stealing
Reviewer Review Type Date Requested Status
Cris Dywan Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+258785@code.qastaging.launchpad.net

Commit message

Prevent the mouse events from being stolen while dragging the slider.

Description of the change

Prevent the mouse events from being stolen while dragging the slider.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1188
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/2202/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2712/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/893/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-vivid-amd64-ci/26/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-vivid-armhf-ci/26/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2710/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/1073/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/2202/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Cris Dywan (kalikiana) wrote :

I'm a bit suspicious of the unit test.. why are you removing the interactive check?

review: Needs Fixing
Reply

Unmerged revisions

1188. By Nick Dedekind

Prevent mouse stealing while sliding

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: