Unity

Merge lp://qastaging/~nick-dedekind/unity/lp1038944.preview-open-flicker into lp://qastaging/unity

  1. lp1038944.preview-open-flicker
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Michal Hruby
Approved revision: no longer in the source branch.
Merged at revision: 2680
Proposed branch: lp://qastaging/~nick-dedekind/unity/lp1038944.preview-open-flicker
Merge into: lp://qastaging/unity
Diff against target: 205 lines (+71/-35)
2 files modified
dash/previews/PreviewContainer.cpp (+44/-29)
manual-tests/Preview.txt (+27/-6)
To merge this branch: bzr merge lp://qastaging/~nick-dedekind/unity/lp1038944.preview-open-flicker
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Brandon Schaefer (community) Approve
Andrea Azzarone (community) Needs Fixing
Sam Spilsbury (community) Needs Information
Review via email: mp+120558@code.qastaging.launchpad.net

Commit message

Fixed a layout flicker when first opening previews (LP#1038944).

Description of the change

Fixed a layout flicker when first opening previews (LP#1038944).

Updates geometry of the previews when the preview content layout changes.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Looks okay. Are there any tests for this code?

review: Needs Information
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

No, there aren't any tests for this.

Revision history for this message
Andrea Azzarone (azzar1) wrote :

A manual test should be ok here.

review: Needs Fixing
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Mnaual test added.

Revision history for this message
Andrea Cimitan (cimi) wrote :

Typo in the manual test, also you can do the opposite (starting from full screen and resizing to desktop)

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> Typo in the manual test, also you can do the opposite (starting from full
> screen and resizing to desktop)

Fixed.

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Tests work, confirmed working as well. Looks good to me :).

review: Approve
Revision history for this message
Michal Hruby (mhr3) wrote :

Works great, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.