Merge lp://qastaging/~nick-dedekind/unity/preview-button-navigation into lp://qastaging/unity
Proposed by
Nick Dedekind
| Status: | Merged |
|---|---|
| Approved by: | Nick Dedekind |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2708 |
| Proposed branch: | lp://qastaging/~nick-dedekind/unity/preview-button-navigation |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
592 lines (+254/-98) 8 files modified
dash/DashView.cpp (+6/-3) dash/previews/ActionButton.cpp (+3/-30) dash/previews/ActionButton.h (+5/-3) dash/previews/Preview.cpp (+166/-6) dash/previews/Preview.h (+8/-1) dash/previews/PreviewContainer.cpp (+61/-55) dash/previews/PreviewContainer.h (+3/-0) dash/previews/PreviewNavigator.h (+2/-0) |
| To merge this branch: | bzr merge lp://qastaging/~nick-dedekind/unity/preview-button-navigation |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
| John Lea (community) | design | Approve | |
|
Review via email:
|
|||
Commit message
Enabled focus navigation for dash preview buttons.
Description of the change
Enabled focus navigation for dash preview buttons.
To post a comment you must log in.
Revision history for this message
| John Lea (johnlea) | # |
review:
Approve
(design)
Revision history for this message
| Unity Merger (unity-merger) wrote | # |
Revision history for this message
| Unity Merger (unity-merger) wrote | # |
Revision history for this message
| Unity Merger (unity-merger) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Works great, autopilot tests will be done in a separate branch.