Unity 8

Merge lp://qastaging/~nick-dedekind/unity8/lp1336715.server-value-reassert into lp://qastaging/unity8

  1. lp1336715.server-value-reassert
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Michał Sawicz
Approved revision: 1356
Merged at revision: 1417
Proposed branch: lp://qastaging/~nick-dedekind/unity8/lp1336715.server-value-reassert
Merge into: lp://qastaging/unity8
Diff against target: 100 lines (+53/-9)
2 files modified
qml/Panel/Indicators/MenuItemFactory.qml (+36/-8)
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml (+17/-1)
To merge this branch: bzr merge lp://qastaging/~nick-dedekind/unity8/lp1336715.server-value-reassert
Reviewer Review Type Date Requested Status
Michał Sawicz Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+237822@code.qastaging.launchpad.net

Commit message

Added timer to re-assert server value after indicator menu item activation.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1354
http://jenkins.qa.ubuntu.com/job/unity8-ci/4591/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5768
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1577
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1687
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1685
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5429
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7020
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7020/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14438

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4591/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Could you please explain / comment why this is needed?

review: Needs Information
lp://qastaging/~nick-dedekind/unity8/lp1336715.server-value-reassert updated
1355. By Nick Dedekind

added code comments

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> Could you please explain / comment why this is needed?

Done.

Revision history for this message
Michał Sawicz (saviq) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Not yet, will do in silo
 * Did CI run pass? If not, please explain why.
Meh, trunk and AP broken.
 * Did you make sure that the branch does not contain spurious tags?
Yes.

review: Approve (code)
lp://qastaging/~nick-dedekind/unity8/lp1336715.server-value-reassert updated
1356. By Nick Dedekind

typo

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1355
http://jenkins.qa.ubuntu.com/job/unity8-ci/4613/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5829/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1599
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1709
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1707
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5482/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7081
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7081/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14525

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4613/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1356
http://jenkins.qa.ubuntu.com/job/unity8-ci/4618/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5841
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1604
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1714
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1712
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5494
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7093
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7093/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14537

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4618/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

OK this is not good.

The steps from https://code.launchpad.net/~nick-dedekind/unity8/lp1336715-checkable-bindings/+merge/234503/comments/582588 are still valid.

When enabling flight mode, the switch goes on, off, then on again within 2-3s or so, and I got stuck in flight mode now.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1356
http://jenkins.qa.ubuntu.com/job/unity8-ci/4694/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6048
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1680
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1790
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1788
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5668
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7300
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7300/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14833

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4694/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> OK this is not good.
>
> The steps from https://code.launchpad.net/~nick-dedekind/unity8/lp1336715
> -checkable-bindings/+merge/234503/comments/582588 are still valid.

This is due to broken binding in the system settings checkboxes/switches.
https://code.launchpad.net/~nick-dedekind/ubuntu-system-settings/lp1336715.check.sync/+merge/239494

>
> When enabling flight mode, the switch goes on, off, then on again within 2-3s
> or so, and I got stuck in flight mode now.

Um, not really sure about this one. I'll need to check it out with the fix to the system settings.

Revision history for this message
Michał Sawicz (saviq) wrote :

OK, the getting stuck part I suspect to be the backend side.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches