Merge lp://qastaging/~niclasl/granite/fix-1034835 into lp://qastaging/~elementary-pantheon/granite/granite
Proposed by
Niclas Lockner
| Status: | Rejected |
|---|---|
| Rejected by: | David Gomes |
| Proposed branch: | lp://qastaging/~niclasl/granite/fix-1034835 |
| Merge into: | lp://qastaging/~elementary-pantheon/granite/granite |
| Diff against target: |
41 lines (+23/-1) 1 file modified
lib/Widgets/DynamicNotebook.vala (+23/-1) |
| To merge this branch: | bzr merge lp://qastaging/~niclasl/granite/fix-1034835 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Gomes (community) | Disapprove | ||
|
Review via email:
|
|||
Description of the change
Don't create new tabs if double-clicks are done close to the edges on the DynamicNotebook widget. Fixes #1034835
To post a comment you must log in.
Unmerged revisions
- 674. By Niclas Lockner
-
Restore the separate press event handler for the add button
- 673. By Niclas Lockner
-
Do not add tabs if the edges of the tab bar are double-clicked
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'm sorry, I really appreciate the fix and it does work for me, but its importance doesn't overcome the fix's hackyness.