Merge lp://qastaging/~nicopace/charms/trusty/python-django/allowed_host_patch into lp://qastaging/charms/python-django
Proposed by
nicopace
| Status: | Merged |
|---|---|
| Merged at revision: | 37 |
| Proposed branch: | lp://qastaging/~nicopace/charms/trusty/python-django/allowed_host_patch |
| Merge into: | lp://qastaging/charms/python-django |
| Diff against target: |
12 lines (+2/-1) 1 file modified
hooks/hooks.py (+2/-1) |
| To merge this branch: | bzr merge lp://qastaging/~nicopace/charms/trusty/python-django/allowed_host_patch |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Ceppi (community) | Approve | ||
| Kevin W Monroe | Approve | ||
|
Review via email:
|
|||
Description of the change
there is a bug that rised when implementing gunicorn tests, that showed a 400 error on every request to gunicorn published python-django charm.
While I was digging over that bug, i discovered that, despite the documentation stated that if you don't specify a django_
This patch solves that problem.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I was able to verify the 400 errors without your changes, and I saw the default hostname/fqdn/ip were not being set in ./juju-
I then applied your changes and verified successful page requests as well as correct defaults in 30-allowed.py when django_
We'll get an official ~charmer ack soon, but until then, +1 LGTM. Thanks for the fix!