Juju Charms Collection
squid-reverseproxy package

Merge lp://qastaging/~nicopace/charms/trusty/squid-reverseproxy/all-tests into lp://qastaging/charms/trusty/squid-reverseproxy

  1. Trusty Tahr (14.04)
  2. all-tests
  3. Merge into trunk
Proposed by nicopace
Status: Merged
Merged at revision: 53
Proposed branch: lp://qastaging/~nicopace/charms/trusty/squid-reverseproxy/all-tests
Merge into: lp://qastaging/charms/trusty/squid-reverseproxy
Diff against target: 481 lines (+432/-0)
10 files modified
tests/00-setup (+16/-0)
tests/12-nagios.py (+46/-0)
tests/13-squid-apache.py (+44/-0)
tests/14-listening-port.py (+50/-0)
tests/15-port-options.py (+71/-0)
tests/16-https.py (+59/-0)
tests/17-via.py (+52/-0)
tests/19-snmp.py (+45/-0)
tests/cert.cert (+21/-0)
tests/cert.key (+28/-0)
To merge this branch: bzr merge lp://qastaging/~nicopace/charms/trusty/squid-reverseproxy/all-tests
Reviewer Review Type Date Requested Status
Whit Morriss (community) Disapprove
charmers Pending
Review via email: mp+251999@code.qastaging.launchpad.net

Description of the change

Battery of tests for squid-reverseproxy.
They will all fail, as there is an open bug on this charm: https://bugs.launchpad.net/charms/+source/squid-reverseproxy/+bug/1426152

To post a comment you must log in.
Revision history for this message
Whit Morriss (whitmo) wrote :

Merges cleanly

Revision history for this message
Whit Morriss (whitmo) wrote :

https://gist.github.com/whitmo/8a30bbb4bbf9a5b01ac8

Package install and python compatibility issue.

-1 needs fixing

review: Disapprove
Revision history for this message
nicopace (nicopace) wrote :

The test implementation doesn't have to fix existing issues.
This charm already fails to install without this patch.

On Tuesday, March 10, 2015, Whit Morriss <email address hidden> wrote:

> Review: Disapprove
>
> https://gist.github.com/whitmo/8a30bbb4bbf9a5b01ac8
>
> Package install and python compatibility issue.
>
> -1 needs fixing
> --
>
> https://code.launchpad.net/~nicopace/charms/trusty/squid-reverseproxy/all-tests/+merge/251999
> You are the owner of
> lp:~nicopace/charms/trusty/squid-reverseproxy/all-tests.
>

--
Ing. Nicolás Pace

Revision history for this message
nicopace (nicopace) wrote :

The test implementation doesn't have to fix existing issues.
This charm already fails to install without this patch.

Revision history for this message
Whit Morriss (whitmo) wrote :

while true, I can't recommend merging and pushing to the store while there
is this issue.

-w

On Tue, Mar 10, 2015 at 10:42 AM, nicopace <email address hidden> wrote:

> The test implementation doesn't have to fix existing issues.
> This charm already fails to install without this patch.
> --
>
> https://code.launchpad.net/~nicopace/charms/trusty/squid-reverseproxy/all-tests/+merge/251999
> You are reviewing the proposed merge of
> lp:~nicopace/charms/trusty/squid-reverseproxy/all-tests into
> lp:charms/trusty/squid-reverseproxy.
>

--
---------------
D. Whit Morriss
Developer, Juju Ecosystem
Canonical USA

Revision history for this message
Whit Morriss (whitmo) wrote :

nico, I'm attempting to contact the maintainers to get the base issues fixed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: