Merge lp://qastaging/~nicovdw/unity/fix_for_731212_and_741346 into lp://qastaging/unity

Proposed by Nico van der Walt
Status: Merged
Merged at revision: 1031
Proposed branch: lp://qastaging/~nicovdw/unity/fix_for_731212_and_741346
Merge into: lp://qastaging/unity
Diff against target: 62 lines (+25/-7)
1 file modified
src/Launcher.cpp (+25/-7)
To merge this branch: bzr merge lp://qastaging/~nicovdw/unity/fix_for_731212_and_741346
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+54627@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Nico van der Walt (nicovdw) wrote :

Hi Didier,

I have uploaded this branch to replace the previous one. This is a much more elegant solution. I have removed the #defines as the original values is never used again.

All the shortcut label icons are now redrawn upon resizing the launcher and they look much nicer now.

The alignment issue for the 'Application' and 'Files & Folders' items is also resolved.

I have created a new bug report for the scaling and linked this branch to both of the bug reports.

I hope everything is in order. I'm new to launchpad and still learning the ropes :-)

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Code looks good. and all your launchpad workflow is perfect :-) Thanks a lot!

However, my brain is almost dead, I'll check give the final checkout on Monday to be sure to have a clean and fresh one ;)
Nice work!

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Works perfectly fine and code looks good, merging! :)

Thanks again for your contribution there

review: Approve
Revision history for this message
Nico van der Walt (nicovdw) wrote :

Thanks Didier! It feels great to make my first code contribution to Ubuntu.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thank *you* ;)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.