Charm Helpers

Merge lp://qastaging/~niedbalski/charm-helpers/fix-lp-1489053 into lp://qastaging/charm-helpers

  1. fix-lp-1489053
  2. Merge into devel
Proposed by Jorge Niedbalski
Status: Merged
Merged at revision: 434
Proposed branch: lp://qastaging/~niedbalski/charm-helpers/fix-lp-1489053
Merge into: lp://qastaging/charm-helpers
Diff against target: 48 lines (+20/-2)
2 files modified
charmhelpers/contrib/network/ip.py (+5/-1)
tests/contrib/network/test_ip.py (+15/-1)
To merge this branch: bzr merge lp://qastaging/~niedbalski/charm-helpers/fix-lp-1489053
Reviewer Review Type Date Requested Status
Felipe Reyes (community) Approve
Review via email: mp+269255@code.qastaging.launchpad.net

Description of the change

This is the charm-helpers fix required to fix LP: #1489053

To post a comment you must log in.
Revision history for this message
Felipe Reyes (freyes) wrote :

Jorge, there is a minor detail in your change.

review: Needs Fixing
lp://qastaging/~niedbalski/charm-helpers/fix-lp-1489053 updated
435. By Jorge Niedbalski

addressing freyes comment

Revision history for this message
Felipe Reyes (freyes) wrote :

LGTM, all tests pass

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches