Charm Helpers

Merge lp://qastaging/~niedbalski/charm-helpers/lp-1461669 into lp://qastaging/charm-helpers

lp-1461669
Merge into devel

Proposed by Jorge Niedbalski on 2015-06-03

Status:

Merged

Merged at revision:

382

Proposed branch:

lp://qastaging/~niedbalski/charm-helpers/lp-1461669

Merge into:

lp://qastaging/charm-helpers

Diff against target:

82 lines (+45/-9)

2 files modified

charmhelpers/contrib/database/mysql.py (+11/-9)
tests/contrib/database/test_mysql.py (+34/-0)

To merge this branch:

bzr merge lp://qastaging/~niedbalski/charm-helpers/lp-1461669

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Mario Splivalo (community)		Approve on 2015-06-03
Billy Olsen		Approve on 2015-06-03
Felipe Reyes (community)		Approve on 2015-06-03
charmers	2015-06-03	Pending
Review via email: mp+261029@code.qastaging.launchpad.net

Description of the change

Charm-helpers fix for 1461669

Revision history for this message

Felipe Reyes (freyes) wrote on 2015-06-03:

LGTM, +1

review: Approve

lp://qastaging/~niedbalski/charm-helpers/lp-1461669 updated on 2015-06-03

383. By Jorge Niedbalski on 2015-06-03: Move log to any size

Revision history for this message

Billy Olsen (billy-olsen) wrote on 2015-06-03:

LGTM. In a separate mp, I propose we set the default value to something a bit smarter than 80% of the total RAM due to the lxc limitations.

review: Approve

Revision history for this message

Mario Splivalo (mariosplivalo) wrote on 2015-06-03:

LGTM too. The default is 50%, although, maybe it would be best to have default of 256M, unless available memory is less than that (then default to 20% of RAM, or something like it)?

review: Approve