Merge lp://qastaging/~niedbalski/charms/precise/rabbitmq-server/trunk into lp://qastaging/charms/trusty/rabbitmq-server

Proposed by Jorge Niedbalski
Status: Merged
Merged at revision: 59
Proposed branch: lp://qastaging/~niedbalski/charms/precise/rabbitmq-server/trunk
Merge into: lp://qastaging/charms/trusty/rabbitmq-server
Diff against target: 38 lines (+16/-4)
1 file modified
hooks/rabbitmq_server_relations.py (+16/-4)
To merge this branch: bzr merge lp://qastaging/~niedbalski/charms/precise/rabbitmq-server/trunk
Reviewer Review Type Date Requested Status
Matt Bruzek (community) Approve
Review via email: mp+234399@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-09-11.

Description of the change

- Fixes bug lp:1315034
- Only restarts and updates nrpe checks if the HA relation has been made and
the node is marked as active, otherwise will log a message indicating that the
node is not marked as active.

To post a comment you must log in.
Revision history for this message
Matt Bruzek (mbruzek) wrote :

+1 LGTM I tested this on hp-cloud and all looked well. Unit tests would really be nice for rabbitmq-server because it is hard to set up. Thanks for your work here.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches