Merge lp://qastaging/~niedbalski/charms/trusty/ceilometer-agent/fix-lp1444015 into lp://qastaging/~openstack-charmers-archive/charms/trusty/ceilometer-agent/next

Proposed by Jorge Niedbalski
Status: Merged
Merged at revision: 51
Proposed branch: lp://qastaging/~niedbalski/charms/trusty/ceilometer-agent/fix-lp1444015
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/ceilometer-agent/next
Diff against target: 80 lines (+28/-3)
2 files modified
hooks/ceilometer_hooks.py (+5/-2)
unit_tests/test_ceilometer_hooks.py (+23/-1)
To merge this branch: bzr merge lp://qastaging/~niedbalski/charms/trusty/ceilometer-agent/fix-lp1444015
Reviewer Review Type Date Requested Status
Billy Olsen Approve
Felipe Reyes Approve
Review via email: mp+256172@code.qastaging.launchpad.net

Description of the change

Fixes 1444015

To post a comment you must log in.
Revision history for this message
Felipe Reyes (freyes) wrote :

@niedbalski, LGTM

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #3117 ceilometer-agent-next for niedbalski mp256172
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/3117/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #3329 ceilometer-agent-next for niedbalski mp256172
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/3329/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #3150 ceilometer-agent-next for niedbalski mp256172
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/10822842/
Build: http://10.245.162.77:8080/job/charm_amulet_test/3150/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

LGTM, Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches