Juju Charms Collection
nova-cloud-controller package

Merge lp://qastaging/~niedbalski/charms/trusty/nova-cloud-controller/fix-lp-1309746 into lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-cloud-controller/trunk

  1. Trusty Tahr (14.04)
  2. fix-lp-1309746
  3. Merge into trunk
Proposed by Jorge Niedbalski
Status: Merged
Merged at revision: 75
Proposed branch: lp://qastaging/~niedbalski/charms/trusty/nova-cloud-controller/fix-lp-1309746
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-cloud-controller/trunk
Diff against target: 15 lines (+4/-1)
1 file modified
hooks/nova_cc_utils.py (+4/-1)
To merge this branch: bzr merge lp://qastaging/~niedbalski/charms/trusty/nova-cloud-controller/fix-lp-1309746
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Abstain
OpenStack Charmers Pending
Review via email: mp+216488@code.qastaging.launchpad.net

Description of the change

Fixes bug lp:1309746

To post a comment you must log in.
Revision history for this message
James Troup (elmo) wrote :

I believe the following line:

+ if not keys[-1] == '\n':

would be more idiomatically written:

+ if not keys.endswith('\n'):

Other than it LGTM, FWIW.

lp://qastaging/~niedbalski/charms/trusty/nova-cloud-controller/fix-lp-1309746 updated
73. By Jorge Niedbalski

Fix for 1309746 , fixes suggestion from james troup

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Hey @elmo,

Fixed according to your observation.

Thanks!

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Leaving for openstack-charmers

review: Abstain

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches