Merge lp://qastaging/~niedbalski/charms/trusty/nova-compute/fix-lp-1518001 into lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next
Proposed by
Jorge Niedbalski
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~niedbalski/charms/trusty/nova-compute/fix-lp-1518001 |
| Merge into: | lp://qastaging/~openstack-charmers-archive/charms/trusty/nova-compute/next |
| Diff against target: |
195 lines (+73/-9) 8 files modified
config.yaml (+12/-6) hooks/charmhelpers/contrib/openstack/context.py (+14/-0) hooks/nova_compute_utils.py (+2/-1) templates/havana/nova.conf (+5/-1) templates/icehouse/nova.conf (+6/-1) templates/juno/nova.conf (+5/-0) templates/kilo/nova.conf (+7/-0) unit_tests/test_nova_compute_utils.py (+22/-0) |
| To merge this branch: | bzr merge lp://qastaging/~niedbalski/charms/trusty/nova-compute/fix-lp-1518001 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Page | Needs Information | ||
|
Review via email:
|
|||
Description of the change
Dear Maintainer,
This is a fix for LP: #1518001 ,
- Adds the LibvirtConfigFlags context
- Adds a new configuration parameter (libvirt-flags) which
adds entries into the [libvirt] section of the nova.conf file.
- Adds unit tests for validate.
To post a comment you must log in.
Revision history for this message
| uosci-testing-bot (uosci-testing-bot) wrote | # |
Revision history for this message
| uosci-testing-bot (uosci-testing-bot) wrote | # |
Revision history for this message
| uosci-testing-bot (uosci-testing-bot) wrote | # |
Unmerged revisions
- 185. By Jorge Niedbalski
-
Added unit tests
- 184. By Jorge Niedbalski
-
Fix for LP: #1518001
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Question - what's the context for configuring this libvirt section option?
Is this required when deploying with a certain set of charms? If so we should not rely on configuration options on the charm todo this sort of thing.