Juju Charms Collection
percona-cluster package

Merge lp://qastaging/~niedbalski/charms/trusty/percona-cluster/backport-fix-lp1461669 into lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/trunk

  1. Trusty Tahr (14.04)
  2. backport-fix-lp1461669
  3. Merge into trunk
Proposed by Jorge Niedbalski
Status: Merged
Merged at revision: 60
Proposed branch: lp://qastaging/~niedbalski/charms/trusty/percona-cluster/backport-fix-lp1461669
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/trunk
Diff against target: 79 lines (+22/-12)
3 files modified
config.yaml (+10/-2)
hooks/charmhelpers/contrib/database/mysql.py (+11/-9)
templates/my.cnf (+1/-1)
To merge this branch: bzr merge lp://qastaging/~niedbalski/charms/trusty/percona-cluster/backport-fix-lp1461669
Reviewer Review Type Date Requested Status
Felipe Reyes Approve
Billy Olsen Approve
charmers Pending
Review via email: mp+261130@code.qastaging.launchpad.net

Description of the change

Stable backport of fix #1461669

To post a comment you must log in.
Revision history for this message
Billy Olsen (billy-olsen) wrote :

LGTM, Approved.

review: Approve
Revision history for this message
Felipe Reyes (freyes) :
review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #4743 percona-cluster for niedbalski mp261130
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/4743/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #5064 percona-cluster for niedbalski mp261130
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/11571610/
Build: http://10.245.162.77:8080/job/charm_lint_check/5064/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4471 percona-cluster for niedbalski mp261130
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/11571633/
Build: http://10.245.162.77:8080/job/charm_amulet_test/4471/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

False negative on the lint failure? I don't get the lint error locally and visually inspecting it, this error doesn't quite make sense.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: