Merge lp://qastaging/~niedbalski/charms/trusty/percona-cluster/fix-default-password-grant into lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/trunk

Proposed by Jorge Niedbalski
Status: Merged
Approved by: Edward Hope-Morley
Approved revision: 39
Merge reported by: Edward Hope-Morley
Merged at revision: not available
Proposed branch: lp://qastaging/~niedbalski/charms/trusty/percona-cluster/fix-default-password-grant
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/trunk
Diff against target: 39 lines (+13/-7)
1 file modified
hooks/percona_hooks.py (+13/-7)
To merge this branch: bzr merge lp://qastaging/~niedbalski/charms/trusty/percona-cluster/fix-default-password-grant
Reviewer Review Type Date Requested Status
OpenStack Charmers Pending
Edward Hope-Morley Pending
Review via email: mp+236408@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-09-29.

Description of the change

If no sst-password is specified then , a randomly generated one is created using pwgen. This
password is correctly set on the configuration file ( my.cnf ) but the replication permissions are set incorrectly.

The charm is performing:

GRANT RELOAD, LOCK TABLES, REPLICATION CLIENT ON *.* TO 'sstuser'@'localhost' IDENTIFIED BY 'None'

Replication:

$ juju deploy percona-cluster
$ juju add-unit percona-cluster
$ juju ssh 1 -e service mysql restart

This will fail due to no permissions for perform the reload on the cluster.

The linked branch , fixes this issue.

To post a comment you must log in.
Revision history for this message
Edward Hope-Morley (hopem) wrote : Posted in a previous version of this proposal

$ make lint
hooks/percona_hooks.py:91:41: E128 continuation line under-indented for visual indent
make: *** [lint] Error 1

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

Fixed.

niedbalski@theos-mobile:~/src/juju/charms/trusty/percona-cluster$ make lint
W: No icon.svg file.

Revision history for this message
Edward Hope-Morley (hopem) wrote : Posted in a previous version of this proposal

LGTM, good catch

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: