Juju Charms Collection
percona-cluster package

Merge lp://qastaging/~niedbalski/charms/trusty/percona-cluster/fix-lp1461669 into lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next

  1. Trusty Tahr (14.04)
  2. fix-lp1461669
  3. Merge into next
Proposed by Jorge Niedbalski
Status: Merged
Approved by: Billy Olsen
Approved revision: 64
Merged at revision: 63
Proposed branch: lp://qastaging/~niedbalski/charms/trusty/percona-cluster/fix-lp1461669
Merge into: lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next
Diff against target: 79 lines (+22/-12)
3 files modified
config.yaml (+10/-2)
hooks/charmhelpers/contrib/database/mysql.py (+11/-9)
templates/my.cnf (+1/-1)
To merge this branch: bzr merge lp://qastaging/~niedbalski/charms/trusty/percona-cluster/fix-lp1461669
Reviewer Review Type Date Requested Status
Billy Olsen Approve
Felipe Reyes Approve
Review via email: mp+261092@code.qastaging.launchpad.net

Description of the change

Fixes LP bug: #1461669

To post a comment you must log in.
Revision history for this message
Felipe Reyes (freyes) wrote :

Hi Jorge, just a minor comment, the rest LGTM.

review: Needs Fixing
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #4736 percona-cluster-next for niedbalski mp261092
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/4736/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #5057 percona-cluster-next for niedbalski mp261092
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/5057/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4464 percona-cluster-next for niedbalski mp261092
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/11567355/
Build: http://10.245.162.77:8080/job/charm_amulet_test/4464/

lp://qastaging/~niedbalski/charms/trusty/percona-cluster/fix-lp1461669 updated
64. By Jorge Niedbalski

Addressed @freyes comment

Revision history for this message
Felipe Reyes (freyes) wrote :

Thanks Jorge, LGTM

review: Approve
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #4737 percona-cluster-next for niedbalski mp261092
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/4737/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #5058 percona-cluster-next for niedbalski mp261092
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/5058/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #4465 percona-cluster-next for niedbalski mp261092
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/11567908/
Build: http://10.245.162.77:8080/job/charm_amulet_test/4465/

Revision history for this message
Billy Olsen (billy-olsen) wrote :

LGTM Approved. Thanks for the submission Jorge!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches