Merge lp://qastaging/~niedbalski/ubuntu/vivid/rpcbind/fix-lp-1430181 into lp://qastaging/ubuntu/vivid/rpcbind

Proposed by Jorge Niedbalski
Status: Work in progress
Proposed branch: lp://qastaging/~niedbalski/ubuntu/vivid/rpcbind/fix-lp-1430181
Merge into: lp://qastaging/ubuntu/vivid/rpcbind
Diff against target: 274 lines (+254/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/rcpbind-tcp-bind-specific-addrs.patch (+245/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~niedbalski/ubuntu/vivid/rpcbind/fix-lp-1430181
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+253260@code.qastaging.launchpad.net

Description of the change

[Description]

There is no way to prevent rpcbind from listening on all interfaces for TCP connections. The setting "-h" only applies to UDP connections.

Without this patch, starting rpcbind with -h makes no effect to listen on a specific address:

$ rpcbind -h 192.168.100.2

tcp 0 0 0.0.0.0:111 0.0.0.0:* LISTEN 22011/rpcbind
tcp6 0 0 :::111 :::* LISTEN 22011/rpcbind
udp 0 0 127.0.0.1:111 0.0.0.0:* 22011/rpcbind
udp 0 0 0.0.0.0:986 0.0.0.0:* 22011/rpcbind
udp6 0 0 ::1:111 :::* 22011/rpcbind
udp6 0 0 :::986 :::* 22011/rpcbind

With this patch, starting rpcbind with -h makes effect to listen to a specific address

$ rpcbind -h 192.168.100.2

tcp 0 0 192.168.100.2:111 0.0.0.0:* LISTEN 24826/rpcbind
tcp 0 0 127.0.0.1:111 0.0.0.0:* LISTEN 24826/rpcbind
tcp6 0 0 ::1:111 :::* LISTEN 24826/rpcbind

To post a comment you must log in.
Revision history for this message
Robie Basak (racb) wrote :

I'm not sure this is appropriate to land at this point in the cycle, or in its current form, so I've made general review comments in the bug instead of here.

Revision history for this message
Sebastien Bacher (seb128) wrote :

settings as "work in progress" rather than "needs review", seems it needs more work/discussion and is not ready for sponsoring

Unmerged revisions

43. By Jorge Niedbalski

debian/patches/rcpbind-tcp-bind-specific-addrs.patch: Make it possible
for rpcbind(8) to bind TCP listening socket to an IP other than INADDR_ANY.
Fixes Bug LP: #1430181.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches